Skip to content

Commit 693bda0

Browse files
committed
directly return in getExtendInputZp and getI32OutputZp
1 parent 8f72666 commit 693bda0

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1497,18 +1497,18 @@ static Value getExtendInputZp(OpBuilder &builder, Type valueTy,
14971497
auto zpTy = result.getType();
14981498
if (zpTy.getIntOrFloatBitWidth() < 32) {
14991499
if (zpTy.isUnsignedInteger()) {
1500-
result =
1501-
builder.create<arith::ExtUIOp>(loc, builder.getI32Type(), result);
1500+
return builder.create<arith::ExtUIOp>(loc, builder.getI32Type(),
1501+
result);
15021502
} else {
1503-
result =
1504-
builder.create<arith::ExtSIOp>(loc, builder.getI32Type(), result);
1503+
return builder.create<arith::ExtSIOp>(loc, builder.getI32Type(),
1504+
result);
15051505
}
15061506
}
15071507
} else {
15081508
const int32_t bitwidth = valueTy.getIntOrFloatBitWidth();
15091509
// Extend zeropoint for sub-32bits widths.
15101510
const int32_t attrBitwidth = bitwidth > 32 ? bitwidth : 32;
1511-
result = builder.create<arith::ConstantOp>(
1511+
return builder.create<arith::ConstantOp>(
15121512
loc, IntegerAttr::get(builder.getIntegerType(attrBitwidth), *maybeZp));
15131513
}
15141514
return result;
@@ -1528,20 +1528,18 @@ static Value getI32OutputZp(OpBuilder &builder, Type valueTy,
15281528
auto zpTy = result.getType();
15291529
if (zpTy.getIntOrFloatBitWidth() < 32) {
15301530
if (zpTy.isUnsignedInteger()) {
1531-
result =
1532-
builder.create<arith::ExtUIOp>(loc, builder.getI32Type(), result);
1531+
return builder.create<arith::ExtUIOp>(loc, builder.getI32Type(),
1532+
result);
15331533
} else {
1534-
result =
1535-
builder.create<arith::ExtSIOp>(loc, builder.getI32Type(), result);
1534+
return builder.create<arith::ExtSIOp>(loc, builder.getI32Type(),
1535+
result);
15361536
}
15371537
} else if (zpTy.getIntOrFloatBitWidth() > 32) {
1538-
result =
1539-
builder.create<arith::TruncIOp>(loc, builder.getI32Type(), result);
1538+
return builder.create<arith::TruncIOp>(loc, builder.getI32Type(), result);
15401539
}
15411540
} else {
1542-
const int32_t attrBitwidth = 32;
1543-
result = builder.create<arith::ConstantOp>(
1544-
loc, IntegerAttr::get(builder.getIntegerType(attrBitwidth), *maybeZp));
1541+
return builder.create<arith::ConstantOp>(
1542+
loc, IntegerAttr::get(builder.getIntegerType(32), *maybeZp));
15451543
}
15461544
return result;
15471545
}

0 commit comments

Comments
 (0)