making code clearer

joaosaffran · joaosaffran · commit 69f581a7483c · 2025-02-07T20:06:00.000Z
diff --git a/llvm/include/llvm/BinaryFormat/DXContainer.h b/llvm/include/llvm/BinaryFormat/DXContainer.h
@@ -557,10 +557,11 @@ struct RootSignatureValidations {
   }
 
   static Expected<uint32_t> validateVersion(uint32_t Version) {
-    if (Version < 1 || Version > 2)
-      return llvm::make_error<BinaryStreamError>(
-          "Invalid Root Signature Version");
-    return Version;
+    if (Version == 1 || Version == 2)
+      return Version;
+
+    return llvm::make_error<BinaryStreamError>(
+        "Invalid Root Signature Version");
   }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -557,10 +557,11 @@ struct RootSignatureValidations {`
`557`	`557`	`}`
`558`	`558`
`559`	`559`	`static Expected<uint32_t> validateVersion(uint32_t Version) {`
`560`		`- if (Version < 1 \|\| Version > 2)`
`561`		`- return llvm::make_error<BinaryStreamError>(`
`562`		`- "Invalid Root Signature Version");`
`563`		`- return Version;`
	`560`	`+ if (Version == 1 \|\| Version == 2)`
	`561`	`+ return Version;`
	`562`	`+`
	`563`	`+ return llvm::make_error<BinaryStreamError>(`
	`564`	`+ "Invalid Root Signature Version");`
`564`	`565`	`}`
`565`	`566`	`};`
`566`	`567`