Skip to content

Commit 69fc6df

Browse files
committed
[RISCV] Simplify macros used by RISCVInstrInfo::convertToThreeAddress. NFC
Merge some macros that are only used once by another macro. Rename macros to remove _MF4 where not needed. I suspect these are artifacts from FP being split from integer in the past.
1 parent a591bd2 commit 69fc6df

File tree

1 file changed

+12
-24
lines changed

1 file changed

+12
-24
lines changed

llvm/lib/Target/RISCV/RISCVInstrInfo.cpp

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4224,38 +4224,32 @@ bool RISCVInstrInfo::simplifyInstruction(MachineInstr &MI) const {
42244224
#define CASE_WIDEOP_OPCODE_COMMON(OP, LMUL) \
42254225
RISCV::PseudoV##OP##_##LMUL##_TIED
42264226

4227-
#define CASE_WIDEOP_OPCODE_LMULS_MF4(OP) \
4228-
CASE_WIDEOP_OPCODE_COMMON(OP, MF4): \
4227+
#define CASE_WIDEOP_OPCODE_LMULS(OP) \
4228+
CASE_WIDEOP_OPCODE_COMMON(OP, MF8): \
4229+
case CASE_WIDEOP_OPCODE_COMMON(OP, MF4): \
42294230
case CASE_WIDEOP_OPCODE_COMMON(OP, MF2): \
42304231
case CASE_WIDEOP_OPCODE_COMMON(OP, M1): \
42314232
case CASE_WIDEOP_OPCODE_COMMON(OP, M2): \
42324233
case CASE_WIDEOP_OPCODE_COMMON(OP, M4)
42334234

4234-
#define CASE_WIDEOP_OPCODE_LMULS(OP) \
4235-
CASE_WIDEOP_OPCODE_COMMON(OP, MF8): \
4236-
case CASE_WIDEOP_OPCODE_LMULS_MF4(OP)
4237-
42384235
#define CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, LMUL) \
42394236
case RISCV::PseudoV##OP##_##LMUL##_TIED: \
42404237
NewOpc = RISCV::PseudoV##OP##_##LMUL; \
42414238
break;
42424239

4243-
#define CASE_WIDEOP_CHANGE_OPCODE_LMULS_MF4(OP) \
4240+
#define CASE_WIDEOP_CHANGE_OPCODE_LMULS(OP) \
4241+
CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, MF8) \
42444242
CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, MF4) \
42454243
CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, MF2) \
42464244
CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, M1) \
42474245
CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, M2) \
42484246
CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, M4)
42494247

4250-
#define CASE_WIDEOP_CHANGE_OPCODE_LMULS(OP) \
4251-
CASE_WIDEOP_CHANGE_OPCODE_COMMON(OP, MF8) \
4252-
CASE_WIDEOP_CHANGE_OPCODE_LMULS_MF4(OP)
4253-
42544248
// FP Widening Ops may by SEW aware. Create SEW aware cases for these cases.
42554249
#define CASE_FP_WIDEOP_OPCODE_COMMON(OP, LMUL, SEW) \
42564250
RISCV::PseudoV##OP##_##LMUL##_##SEW##_TIED
42574251

4258-
#define CASE_FP_WIDEOP_OPCODE_LMULS_MF4(OP) \
4252+
#define CASE_FP_WIDEOP_OPCODE_LMULS(OP) \
42594253
CASE_FP_WIDEOP_OPCODE_COMMON(OP, MF4, E16): \
42604254
case CASE_FP_WIDEOP_OPCODE_COMMON(OP, MF2, E16): \
42614255
case CASE_FP_WIDEOP_OPCODE_COMMON(OP, MF2, E32): \
@@ -4271,7 +4265,7 @@ bool RISCVInstrInfo::simplifyInstruction(MachineInstr &MI) const {
42714265
NewOpc = RISCV::PseudoV##OP##_##LMUL##_##SEW; \
42724266
break;
42734267

4274-
#define CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS_MF4(OP) \
4268+
#define CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS(OP) \
42754269
CASE_FP_WIDEOP_CHANGE_OPCODE_COMMON(OP, MF4, E16) \
42764270
CASE_FP_WIDEOP_CHANGE_OPCODE_COMMON(OP, MF2, E16) \
42774271
CASE_FP_WIDEOP_CHANGE_OPCODE_COMMON(OP, MF2, E32) \
@@ -4281,9 +4275,6 @@ bool RISCVInstrInfo::simplifyInstruction(MachineInstr &MI) const {
42814275
CASE_FP_WIDEOP_CHANGE_OPCODE_COMMON(OP, M2, E32) \
42824276
CASE_FP_WIDEOP_CHANGE_OPCODE_COMMON(OP, M4, E16) \
42834277
CASE_FP_WIDEOP_CHANGE_OPCODE_COMMON(OP, M4, E32) \
4284-
4285-
#define CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS(OP) \
4286-
CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS_MF4(OP)
42874278
// clang-format on
42884279

42894280
MachineInstr *RISCVInstrInfo::convertToThreeAddress(MachineInstr &MI,
@@ -4293,8 +4284,8 @@ MachineInstr *RISCVInstrInfo::convertToThreeAddress(MachineInstr &MI,
42934284
switch (MI.getOpcode()) {
42944285
default:
42954286
return nullptr;
4296-
case CASE_FP_WIDEOP_OPCODE_LMULS_MF4(FWADD_WV):
4297-
case CASE_FP_WIDEOP_OPCODE_LMULS_MF4(FWSUB_WV): {
4287+
case CASE_FP_WIDEOP_OPCODE_LMULS(FWADD_WV):
4288+
case CASE_FP_WIDEOP_OPCODE_LMULS(FWSUB_WV): {
42984289
assert(RISCVII::hasVecPolicyOp(MI.getDesc().TSFlags) &&
42994290
MI.getNumExplicitOperands() == 7 &&
43004291
"Expect 7 explicit operands rd, rs2, rs1, rm, vl, sew, policy");
@@ -4307,8 +4298,8 @@ MachineInstr *RISCVInstrInfo::convertToThreeAddress(MachineInstr &MI,
43074298
switch (MI.getOpcode()) {
43084299
default:
43094300
llvm_unreachable("Unexpected opcode");
4310-
CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS_MF4(FWADD_WV)
4311-
CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS_MF4(FWSUB_WV)
4301+
CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS(FWADD_WV)
4302+
CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS(FWSUB_WV)
43124303
}
43134304
// clang-format on
43144305

@@ -4387,15 +4378,12 @@ MachineInstr *RISCVInstrInfo::convertToThreeAddress(MachineInstr &MI,
43874378
}
43884379

43894380
#undef CASE_WIDEOP_OPCODE_COMMON
4390-
#undef CASE_WIDEOP_OPCODE_LMULS_MF4
43914381
#undef CASE_WIDEOP_OPCODE_LMULS
43924382
#undef CASE_WIDEOP_CHANGE_OPCODE_COMMON
4393-
#undef CASE_WIDEOP_CHANGE_OPCODE_LMULS_MF4
43944383
#undef CASE_WIDEOP_CHANGE_OPCODE_LMULS
43954384
#undef CASE_FP_WIDEOP_OPCODE_COMMON
4396-
#undef CASE_FP_WIDEOP_OPCODE_LMULS_MF4
4385+
#undef CASE_FP_WIDEOP_OPCODE_LMULS
43974386
#undef CASE_FP_WIDEOP_CHANGE_OPCODE_COMMON
4398-
#undef CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS_MF4
43994387
#undef CASE_FP_WIDEOP_CHANGE_OPCODE_LMULS
44004388

44014389
void RISCVInstrInfo::mulImm(MachineFunction &MF, MachineBasicBlock &MBB,

0 commit comments

Comments
 (0)