fix: fixed tests for asctime and removed unnecessary header include

Zishan Mirza · Zishan Mirza · commit 6a84f62adcef · 2025-01-04T01:34:39.000+05:00
statements
diff --git a/libc/src/time/asctime.cpp b/libc/src/time/asctime.cpp
@@ -7,8 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/time/asctime.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
 #include "src/time/time_utils.h"
 
 namespace LIBC_NAMESPACE_DECL {
diff --git a/libc/src/time/asctime_r.cpp b/libc/src/time/asctime_r.cpp
@@ -7,8 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/time/asctime_r.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
 #include "src/time/time_utils.h"
 
 namespace LIBC_NAMESPACE_DECL {
diff --git a/libc/src/time/ctime.cpp b/libc/src/time/ctime.cpp
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "ctime.h"
-#include "time_utils.h"
+#include "src/time/ctime.h"
+#include "src/time/time_utils.h"
 
 namespace LIBC_NAMESPACE_DECL {
 
diff --git a/libc/src/time/ctime_r.cpp b/libc/src/time/ctime_r.cpp
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "ctime_r.h"
-#include "time_utils.h"
+#include "src/time/ctime_r.h"
+#include "src/time/time_utils.h"
 
 namespace LIBC_NAMESPACE_DECL {
 
diff --git a/libc/src/time/linux/localtime.cpp b/libc/src/time/linux/localtime.cpp
@@ -1,5 +1,4 @@
-//===-- Linux implementation of the localtime function
-//------------------------===//
+//===-- Linux implementation of the localtime function --------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
diff --git a/libc/src/time/linux/localtime_r.cpp b/libc/src/time/linux/localtime_r.cpp
@@ -7,8 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/time/localtime_r.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
 #include "src/time/time_utils.h"
 
 namespace LIBC_NAMESPACE_DECL {
diff --git a/libc/src/time/linux/localtime_s.cpp b/libc/src/time/linux/localtime_s.cpp
@@ -7,8 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/time/localtime_s.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
 #include "src/time/time_utils.h"
 
 namespace LIBC_NAMESPACE_DECL {
diff --git a/libc/src/time/time_utils.h b/libc/src/time/time_utils.h
@@ -9,12 +9,10 @@
 #ifndef LLVM_LIBC_SRC_TIME_TIME_UTILS_H
 #define LLVM_LIBC_SRC_TIME_TIME_UTILS_H
 
-#include <time.h>
-
 #include "src/__support/CPP/limits.h"
 #include "src/errno/libc_errno.h"
-#include "timezone.h"
-#include <stdio.h>
+#include "src/time/timezone.h"
+#include <time.h>
 
 namespace LIBC_NAMESPACE_DECL {
 namespace time_utils {
diff --git a/libc/test/src/time/CMakeLists.txt b/libc/test/src/time/CMakeLists.txt
@@ -14,6 +14,7 @@ add_libc_unittest(
   DEPENDS
     libc.src.time.timezone
     libc.src.time.asctime
+    libc.src.stdio.fopen
 )
 
 add_libc_unittest(
@@ -30,6 +31,7 @@ add_libc_unittest(
   DEPENDS
     libc.src.time.timezone
     libc.src.time.asctime_r
+    libc.src.stdio.fopen
 )
 
 add_libc_unittest(
diff --git a/libc/test/src/time/asctime_r_test.cpp b/libc/test/src/time/asctime_r_test.cpp
@@ -6,7 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "src/errno/libc_errno.h"
 #include "src/time/asctime_r.h"
 #include "src/time/time_utils.h"
 #include "test/UnitTest/Test.h"
diff --git a/libc/test/src/time/asctime_test.cpp b/libc/test/src/time/asctime_test.cpp
@@ -6,7 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "src/errno/libc_errno.h"
+#include "src/__support/File/file.h"
 #include "src/time/asctime.h"
 #include "test/UnitTest/Test.h"
 #include "test/src/time/TmHelper.h"

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ add_libc_unittest(`
`14`	`14`	`DEPENDS`
`15`	`15`	`libc.src.time.timezone`
`16`	`16`	`libc.src.time.asctime`
	`17`	`+ libc.src.stdio.fopen`
`17`	`18`	`)`
`18`	`19`
`19`	`20`	`add_libc_unittest(`
`@@ -30,6 +31,7 @@ add_libc_unittest(`
`30`	`31`	`DEPENDS`
`31`	`32`	`libc.src.time.timezone`
`32`	`33`	`libc.src.time.asctime_r`
	`34`	`+ libc.src.stdio.fopen`
`33`	`35`	`)`
`34`	`36`
`35`	`37`	`add_libc_unittest(`