fixup! fixup! Address review comments

mshockwave · mshockwave · commit 6b7f8e9ab525 · 2025-01-27T16:51:52.000-08:00
diff --git a/llvm/lib/CodeGen/InterleavedAccessPass.cpp b/llvm/lib/CodeGen/InterleavedAccessPass.cpp
@@ -644,10 +644,8 @@ static Value *getMask(Value *WideMask, unsigned Factor) {
     SmallVector<Instruction *, 8> DeadInsts;
     if (getVectorInterleaveFactor(IMI, Operands, DeadInsts)) {
       assert(!Operands.empty());
-      Value *FirstOp = Operands[0];
-      if (Operands.size() == Factor &&
-          llvm::all_of(Operands, [=](Value *Op) { return Op == FirstOp; }))
-        return FirstOp;
+      if (Operands.size() == Factor && llvm::all_equal(Operands))
+        return Operands[0];
     }
   }
   if (match(WideMask, m_AllOnes()))

Original file line number	Diff line number	Diff line change
`@@ -644,10 +644,8 @@ static Value getMask(Value WideMask, unsigned Factor) {`
`644`	`644`	`SmallVector<Instruction *, 8> DeadInsts;`
`645`	`645`	`if (getVectorInterleaveFactor(IMI, Operands, DeadInsts)) {`
`646`	`646`	`assert(!Operands.empty());`
`647`		`- Value *FirstOp = Operands[0];`
`648`		`- if (Operands.size() == Factor &&`
`649`		`- llvm::all_of(Operands, [=](Value *Op) { return Op == FirstOp; }))`
`650`		`- return FirstOp;`
	`647`	`+ if (Operands.size() == Factor && llvm::all_equal(Operands))`
	`648`	`+ return Operands[0];`
`651`	`649`	`}`
`652`	`650`	`}`
`653`	`651`	`if (match(WideMask, m_AllOnes()))`