Skip to content

Commit 6bbae4d

Browse files
authored
[RISCV] Add underscores to instructions names for Zimop/Zcmop. (#155289)
This matches the position of the periods in the mnemonics. I didn't rename the intrinsics because I'm not sure who uses them.
1 parent c950a72 commit 6bbae4d

File tree

3 files changed

+21
-20
lines changed

3 files changed

+21
-20
lines changed

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10738,11 +10738,11 @@ SDValue RISCVTargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op,
1073810738
return DAG.getNode(Opc, DL, XLenVT, Op.getOperand(1));
1073910739
}
1074010740
case Intrinsic::riscv_mopr:
10741-
return DAG.getNode(RISCVISD::MOPR, DL, XLenVT, Op.getOperand(1),
10741+
return DAG.getNode(RISCVISD::MOP_R, DL, XLenVT, Op.getOperand(1),
1074210742
Op.getOperand(2));
1074310743

1074410744
case Intrinsic::riscv_moprr: {
10745-
return DAG.getNode(RISCVISD::MOPRR, DL, XLenVT, Op.getOperand(1),
10745+
return DAG.getNode(RISCVISD::MOP_RR, DL, XLenVT, Op.getOperand(1),
1074610746
Op.getOperand(2), Op.getOperand(3));
1074710747
}
1074810748
case Intrinsic::riscv_clmul:
@@ -14877,7 +14877,7 @@ void RISCVTargetLowering::ReplaceNodeResults(SDNode *N,
1487714877
SDValue NewOp =
1487814878
DAG.getNode(ISD::ANY_EXTEND, DL, MVT::i64, N->getOperand(1));
1487914879
SDValue Res = DAG.getNode(
14880-
RISCVISD::MOPR, DL, MVT::i64, NewOp,
14880+
RISCVISD::MOP_R, DL, MVT::i64, NewOp,
1488114881
DAG.getTargetConstant(N->getConstantOperandVal(2), DL, MVT::i64));
1488214882
Results.push_back(DAG.getNode(ISD::TRUNCATE, DL, MVT::i32, Res));
1488314883
return;
@@ -14890,7 +14890,7 @@ void RISCVTargetLowering::ReplaceNodeResults(SDNode *N,
1489014890
SDValue NewOp1 =
1489114891
DAG.getNode(ISD::ANY_EXTEND, DL, MVT::i64, N->getOperand(2));
1489214892
SDValue Res = DAG.getNode(
14893-
RISCVISD::MOPRR, DL, MVT::i64, NewOp0, NewOp1,
14893+
RISCVISD::MOP_RR, DL, MVT::i64, NewOp0, NewOp1,
1489414894
DAG.getTargetConstant(N->getConstantOperandVal(3), DL, MVT::i64));
1489514895
Results.push_back(DAG.getNode(ISD::TRUNCATE, DL, MVT::i32, Res));
1489614896
return;

llvm/lib/Target/RISCV/RISCVInstrInfoZcmop.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ class CMOPInst<bits<3> imm3, string opcodestr>
2222

2323
foreach n = [1, 3, 5, 7, 9, 11, 13, 15] in {
2424
let Predicates = [HasStdExtZcmop] in
25-
def C_MOP # n : CMOPInst<!srl(n, 1), "c.mop." # n>, Sched<[]>;
25+
def C_MOP_ # n : CMOPInst<!srl(n, 1), "c.mop." # n>, Sched<[]>;
2626
}

llvm/lib/Target/RISCV/RISCVInstrInfoZimop.td

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@ class RVInstRMoprr<bits<4> imm4, bits<3> imm3, bits<3> funct3, RISCVOpcode opcod
3333
}
3434

3535
// May-Be-Operations
36-
def riscv_mopr : RVSDNode<"MOPR",
37-
SDTypeProfile<1, 2, [SDTCisInt<0>, SDTCisSameAs<0, 1>,
38-
SDTCisSameAs<0, 2>]>>;
39-
def riscv_moprr : RVSDNode<"MOPRR",
40-
SDTypeProfile<1, 3, [SDTCisInt<0>, SDTCisSameAs<0, 1>,
41-
SDTCisSameAs<0, 2>,
42-
SDTCisSameAs<0, 3>]>>;
36+
def riscv_mop_r : RVSDNode<"MOP_R",
37+
SDTypeProfile<1, 2, [SDTCisInt<0>, SDTCisSameAs<0, 1>,
38+
SDTCisSameAs<0, 2>]>>;
39+
def riscv_mop_rr : RVSDNode<"MOP_RR",
40+
SDTypeProfile<1, 3, [SDTCisInt<0>, SDTCisSameAs<0, 1>,
41+
SDTCisSameAs<0, 2>,
42+
SDTCisSameAs<0, 3>]>>;
4343

4444
let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in
4545
class RVMopr<bits<7> imm7, bits<5> imm5, bits<3> funct3,
@@ -50,31 +50,32 @@ class RVMopr<bits<7> imm7, bits<5> imm5, bits<3> funct3,
5050
let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in
5151
class RVMoprr<bits<4> imm4, bits<3> imm3, bits<3> funct3,
5252
RISCVOpcode opcode, string opcodestr>
53-
: RVInstRMoprr<imm4, imm3, funct3, opcode, (outs GPR:$rd), (ins GPR:$rs1, GPR:$rs2),
53+
: RVInstRMoprr<imm4, imm3, funct3, opcode, (outs GPR:$rd),
54+
(ins GPR:$rs1, GPR:$rs2),
5455
opcodestr, "$rd, $rs1, $rs2">;
5556

5657
foreach i = 0...31 in {
5758
let Predicates = [HasStdExtZimop] in
58-
def MOPR#i : RVMopr<0b1000111, i, 0b100, OPC_SYSTEM, "mop.r."#i>,
59-
Sched<[]>;
59+
def MOP_R_#i : RVMopr<0b1000111, i, 0b100, OPC_SYSTEM, "mop.r."#i>,
60+
Sched<[]>;
6061
}
6162

6263
foreach i = 0...7 in {
6364
let Predicates = [HasStdExtZimop] in
64-
def MOPRR#i : RVMoprr<0b1001, i, 0b100, OPC_SYSTEM, "mop.rr."#i>,
65+
def MOP_RR_#i : RVMoprr<0b1001, i, 0b100, OPC_SYSTEM, "mop.rr."#i>,
6566
Sched<[]>;
6667
}
6768

6869
let Predicates = [HasStdExtZimop] in {
6970
// Zimop instructions
7071
foreach i = 0...31 in {
71-
def : Pat<(XLenVT (riscv_mopr GPR:$rs1, (XLenVT i))),
72-
(!cast<Instruction>("MOPR"#i) GPR:$rs1)>;
72+
def : Pat<(XLenVT (riscv_mop_r GPR:$rs1, (XLenVT i))),
73+
(!cast<Instruction>("MOP_R_"#i) GPR:$rs1)>;
7374
}
7475

7576
foreach i = 0...7 in {
76-
def : Pat<(XLenVT (riscv_moprr GPR:$rs1, GPR:$rs2, (XLenVT i))),
77-
(!cast<Instruction>("MOPRR"#i) GPR:$rs1, GPR:$rs2)>;
77+
def : Pat<(XLenVT (riscv_mop_rr GPR:$rs1, GPR:$rs2, (XLenVT i))),
78+
(!cast<Instruction>("MOP_RR_"#i) GPR:$rs1, GPR:$rs2)>;
7879
}
7980

8081
} // Predicates = [HasStdExtZimop]

0 commit comments

Comments
 (0)