Fix nits

Author: kuilpd

clang/include/clang/AST/ASTContext.h

@@ -1728,7 +1728,8 @@ class ASTContext : public RefCountedBase<ASTContext> {
 
   /// Compute BestType and BestPromotionType for an enum based on the highest
   /// number of negative and positive bits of its elements.
-  bool computeBestEnumTypes(bool isPacked, unsigned NumNegativeBits,
+  /// Returns true if enum width is too large.
+  bool computeBestEnumTypes(bool IsPacked, unsigned NumNegativeBits,
                             unsigned NumPositiveBits, QualType &BestType,
                             QualType &BestPromotionType);
 

clang/include/clang/Sema/Sema.h

@@ -3987,7 +3987,6 @@ class Sema final : public SemaBase {
                           SourceLocation IdLoc, IdentifierInfo *Id,
                           const ParsedAttributesView &Attrs,
                           SourceLocation EqualLoc, Expr *Val);
-
   void ActOnEnumBody(SourceLocation EnumLoc, SourceRange BraceRange,
                      Decl *EnumDecl, ArrayRef<Decl *> Elements, Scope *S,
                      const ParsedAttributesView &Attr);

clang/lib/AST/ASTContext.cpp

@@ -5209,7 +5209,7 @@ QualType ASTContext::getEnumType(const EnumDecl *Decl) const {
   return QualType(newType, 0);
 }
 
-bool ASTContext::computeBestEnumTypes(bool isPacked, unsigned NumNegativeBits,
+bool ASTContext::computeBestEnumTypes(bool IsPacked, unsigned NumNegativeBits,
                                       unsigned NumPositiveBits,
                                       QualType &BestType,
                                       QualType &BestPromotionType) {
@@ -5222,11 +5222,11 @@ bool ASTContext::computeBestEnumTypes(bool isPacked, unsigned NumNegativeBits,
     // If there is a negative value, figure out the smallest integer type (of
     // int/long/longlong) that fits.
     // If it's packed, check also if it fits a char or a short.
-    if (isPacked && NumNegativeBits <= CharWidth &&
+    if (IsPacked && NumNegativeBits <= CharWidth &&
         NumPositiveBits < CharWidth) {
       BestType = SignedCharTy;
       BestWidth = CharWidth;
-    } else if (isPacked && NumNegativeBits <= ShortWidth &&
+    } else if (IsPacked && NumNegativeBits <= ShortWidth &&
                NumPositiveBits < ShortWidth) {
       BestType = ShortTy;
       BestWidth = ShortWidth;
@@ -5251,11 +5251,11 @@ bool ASTContext::computeBestEnumTypes(bool isPacked, unsigned NumNegativeBits,
     // If there is no negative value, figure out the smallest type that fits
     // all of the enumerator values.
     // If it's packed, check also if it fits a char or a short.
-    if (isPacked && NumPositiveBits <= CharWidth) {
+    if (IsPacked && NumPositiveBits <= CharWidth) {
       BestType = UnsignedCharTy;
       BestPromotionType = IntTy;
       BestWidth = CharWidth;
-    } else if (isPacked && NumPositiveBits <= ShortWidth) {
+    } else if (IsPacked && NumPositiveBits <= ShortWidth) {
       BestType = UnsignedShortTy;
       BestPromotionType = IntTy;
       BestWidth = ShortWidth;

clang/lib/Sema/SemaDecl.cpp

@@ -20096,7 +20096,7 @@ void Sema::ActOnEnumBody(SourceLocation EnumLoc, SourceRange BraceRange,
 
     BestWidth = Context.getIntWidth(BestType);
   } else {
-    const bool EnumTooLarge = Context.computeBestEnumTypes(
+    bool EnumTooLarge = Context.computeBestEnumTypes(
         Packed, NumNegativeBits, NumPositiveBits, BestType, BestPromotionType);
     BestWidth = Context.getIntWidth(BestType);
     if (EnumTooLarge)