[llvm][tools] Strip unneeded uses of raw_string_ostream::str() (NFC)

Remove unnecessary layer of indirection.

Author: JOE1994

llvm/tools/llvm-debuginfo-analyzer/llvm-debuginfo-analyzer.cpp

@@ -34,7 +34,7 @@ static void error(std::error_code EC, char const *Fmt, const Ts &...Vals) {
   std::string Buffer;
   raw_string_ostream Stream(Buffer);
   Stream << format(Fmt, Vals...);
-  WithColor::error(errs(), ToolName) << Stream.str() << "\n";
+  WithColor::error(errs(), ToolName) << Buffer << "\n";
   exit(1);
 }
 

llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp

@@ -183,7 +183,7 @@ static Error validateArchitectureName(StringRef ArchitectureName) {
     return createStringError(
         std::errc::invalid_argument,
         "invalid architecture '%s': valid architecture names are %s",
-        ArchitectureName.str().c_str(), OS.str().c_str());
+        ArchitectureName.str().c_str(), Buf.c_str());
   }
   return Error::success();
 }

llvm/tools/llvm-lipo/llvm-lipo.cpp

@@ -142,7 +142,7 @@ static void validateArchitectureName(StringRef ArchitectureName) {
        << "\nValid architecture names are:";
     for (auto arch : MachOObjectFile::getValidArchs())
       OS << " " << arch;
-    reportError(OS.str());
+    reportError(Buf);
   }
 }
 
@@ -241,7 +241,7 @@ static Config parseLipoOptions(ArrayRef<const char *> ArgsArr) {
     OS << "only one of the following actions can be specified:";
     for (auto *Arg : ActionArgs)
       OS << " " << Arg->getSpelling();
-    reportError(OS.str());
+    reportError(Buf);
   }
 
   switch (ActionArgs[0]->getOption().getID()) {

llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp

@@ -106,7 +106,7 @@ static std::string formatSymbol(StringRef Name, uint64_t Address,
   else
     OS << format("0x%" PRIX64, Address);
 
-  return OS.str();
+  return Buffer;
 }
 
 namespace llvm {
@@ -305,7 +305,7 @@ ErrorOr<SymbolRef> Decoder::getSymbolForLocation(
       std::string Buf;
       llvm::raw_string_ostream OS(Buf);
       logAllUnhandledErrors(AddressOrErr.takeError(), OS);
-      report_fatal_error(Twine(OS.str()));
+      report_fatal_error(Twine(Buf));
     }
     // We apply SymbolOffset here directly. We return it separately to allow
     // the caller to print it as an offset on the symbol name.
@@ -1125,7 +1125,7 @@ bool Decoder::dumpXDataRecord(const COFFObjectFile &COFF,
       std::string Buf;
       llvm::raw_string_ostream OS(Buf);
       logAllUnhandledErrors(Name.takeError(), OS);
-      report_fatal_error(Twine(OS.str()));
+      report_fatal_error(Twine(Buf));
     }
 
     ListScope EHS(SW, "ExceptionHandler");
@@ -1164,7 +1164,7 @@ bool Decoder::dumpUnpackedEntry(const COFFObjectFile &COFF,
       std::string Buf;
       llvm::raw_string_ostream OS(Buf);
       logAllUnhandledErrors(FunctionNameOrErr.takeError(), OS);
-      report_fatal_error(Twine(OS.str()));
+      report_fatal_error(Twine(Buf));
     }
     FunctionName = *FunctionNameOrErr;
   }
@@ -1178,7 +1178,7 @@ bool Decoder::dumpUnpackedEntry(const COFFObjectFile &COFF,
       std::string Buf;
       llvm::raw_string_ostream OS(Buf);
       logAllUnhandledErrors(Name.takeError(), OS);
-      report_fatal_error(Twine(OS.str()));
+      report_fatal_error(Twine(Buf));
     }
 
     SW.printString("ExceptionRecord",
@@ -1223,7 +1223,7 @@ bool Decoder::dumpPackedEntry(const object::COFFObjectFile &COFF,
       std::string Buf;
       llvm::raw_string_ostream OS(Buf);
       logAllUnhandledErrors(FunctionNameOrErr.takeError(), OS);
-      report_fatal_error(Twine(OS.str()));
+      report_fatal_error(Twine(Buf));
     }
     FunctionName = *FunctionNameOrErr;
   }
@@ -1322,7 +1322,7 @@ bool Decoder::dumpPackedARM64Entry(const object::COFFObjectFile &COFF,
       std::string Buf;
       llvm::raw_string_ostream OS(Buf);
       logAllUnhandledErrors(FunctionNameOrErr.takeError(), OS);
-      report_fatal_error(Twine(OS.str()));
+      report_fatal_error(Twine(Buf));
     }
     FunctionName = *FunctionNameOrErr;
   }

llvm/tools/llvm-xray/xray-graph.cpp

@@ -368,7 +368,7 @@ GraphRenderer::TimeStat::getString(GraphRenderer::StatType T) const {
                             static_cast<int>(GraphRenderer::StatType::MIN)];
     break;
   }
-  return S.str();
+  return St;
 }
 
 // Returns the quotient between the property T of this and another TimeStat as