#162046 removed urem() call in rotate builtins, called rotl/rotr directly

rdez13 · rdez13 · commit 6c34a8d28f13 · 2025-10-06T12:21:32.000-04:00
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
@@ -14265,7 +14265,7 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
         !EvaluateInteger(E->getArg(1), Amt, Info))
       return false;
 
-    return Success(Val.rotl(Amt.urem(Val.getBitWidth())), E);
+    return Success(Val.rotl(Amt), E);
   }
 
   case Builtin::BI__builtin_rotateright8:
@@ -14282,7 +14282,7 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
         !EvaluateInteger(E->getArg(1), Amt, Info))
       return false;
 
-    return Success(Val.rotr(Amt.urem(Val.getBitWidth())), E);
+    return Success(Val.rotr(Amt), E);
   }
 
   case Builtin::BI__builtin_elementwise_add_sat: {

Original file line number	Diff line number	Diff line change
`@@ -14265,7 +14265,7 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,`
`14265`	`14265`	`!EvaluateInteger(E->getArg(1), Amt, Info))`
`14266`	`14266`	`return false;`
`14267`	`14267`
`14268`		`- return Success(Val.rotl(Amt.urem(Val.getBitWidth())), E);`
	`14268`	`+ return Success(Val.rotl(Amt), E);`
`14269`	`14269`	`}`
`14270`	`14270`
`14271`	`14271`	`case Builtin::BI__builtin_rotateright8:`
`@@ -14282,7 +14282,7 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,`
`14282`	`14282`	`!EvaluateInteger(E->getArg(1), Amt, Info))`
`14283`	`14283`	`return false;`
`14284`	`14284`
`14285`		`- return Success(Val.rotr(Amt.urem(Val.getBitWidth())), E);`
	`14285`	`+ return Success(Val.rotr(Amt), E);`
`14286`	`14286`	`}`
`14287`	`14287`
`14288`	`14288`	`case Builtin::BI__builtin_elementwise_add_sat: {`