Address feedback

Author: IgWod-IMG

mlir/lib/Dialect/SPIRV/IR/ControlFlowOps.cpp

@@ -294,9 +294,9 @@ Block *SwitchOp::getSuccessorForOperands(ArrayRef<Attribute> operands) {
 
   SuccessorRange targets = getTargets();
   if (auto value = llvm::dyn_cast_or_null<IntegerAttr>(operands.front())) {
-    for (const auto &it : llvm::enumerate(literals->getValues<APInt>()))
-      if (it.value() == value.getValue())
-        return targets[it.index()];
+    for (auto [index, literal] : llvm::enumerate(literals->getValues<APInt>()))
+      if (literal == value.getValue())
+        return targets[index];
     return getDefaultTarget();
   }
   return nullptr;

mlir/lib/Dialect/SPIRV/IR/SPIRVOpDefinition.cpp

@@ -147,13 +147,13 @@ printSwitchOpCases(OpAsmPrinter &p, SwitchOp op, Type selectorType,
   if (!literals)
     return;
 
-  for (const auto &it : llvm::enumerate(literals.getValues<APInt>())) {
+  for (auto [index, literal] : llvm::enumerate(literals.getValues<APInt>())) {
     p << ',';
     p.printNewline();
     p << "  ";
-    p << it.value().getLimitedValue();
+    p << literal.getLimitedValue();
     p << ": ";
-    p.printSuccessorAndUseList(targets[it.index()], targetOperands[it.index()]);
+    p.printSuccessorAndUseList(targets[index], targetOperands[index]);
   }
   p.printNewline();
 }

mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp

@@ -783,7 +783,7 @@ LogicalResult Serializer::processSwitchOp(spirv::SwitchOp switchOp) {
   std::optional<mlir::DenseIntElementsAttr> literals = switchOp.getLiterals();
   BlockRange targets = switchOp.getTargets();
   if (literals) {
-    for (auto [literal, target] : llvm::zip(*literals, targets)) {
+    for (auto [literal, target] : llvm::zip_equal(*literals, targets)) {
       arguments.push_back(literal.getLimitedValue());
       uint32_t targetLabelID = getOrCreateBlockID(target);
       arguments.push_back(targetLabelID);