Apply suggestions from code review

Co-authored-by: Andy Kaylor <[email protected]>

Author: mmha

clang/include/clang/CIR/Dialect/IR/CIROps.td

@@ -2227,7 +2227,7 @@ def CIR_ReturnAddrOp : CIR_FuncAddrBuiltinOp<"return_address"> {
       "The return address of the current function, or of one of its callers";
 
   let description = [{
-    Represents call to builtin function ` __builtin_return_address` in CIR.
+    Represents a call to builtin function ` __builtin_return_address` in CIR.
     This builtin function returns the return address of the current function,
     or of one of its callers.
     The `level` argument is number of frames to scan up the call stack.
@@ -2248,7 +2248,7 @@ def CIR_FrameAddrOp : CIR_FuncAddrBuiltinOp<"frame_address"> {
       "The frame address of the current function, or of one of its callers";
 
   let description = [{
-    Represents call to builtin function ` __builtin_frame_address` in CIR.
+    Represents a call to builtin function ` __builtin_frame_address` in CIR.
     This builtin function returns the frame address of the current function,
     or of one of its callers. The frame is the area on the stack that holds
     local variables and saved registers. The frame address is normally the

clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp

@@ -319,11 +319,11 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID,
         e->getArg(0), e->getArg(0)->getType());
     uint64_t level = mlir::cast<cir::IntAttr>(levelAttr).getUInt();
     if (builtinID == Builtin::BI__builtin_return_address) {
-      return RValue::get(builder.create<cir::ReturnAddrOp>(
+      return RValue::get(cir::ReturnAddrOp::create(builder,
           loc, builder.getUInt32(level, loc)));
     }
     return RValue::get(
-        builder.create<cir::FrameAddrOp>(loc, builder.getUInt32(level, loc)));
+        cir::FrameAddrOp::create(builder, loc, builder.getUInt32(level, loc)));
   }
 
   case Builtin::BI__builtin_trap:

clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

@@ -273,7 +273,7 @@ createCallLLVMIntrinsicOp(mlir::ConversionPatternRewriter &rewriter,
                           mlir::Type resultTy, mlir::ValueRange operands) {
   auto intrinsicNameAttr =
       mlir::StringAttr::get(rewriter.getContext(), intrinsicName);
-  return rewriter.create<mlir::LLVM::CallIntrinsicOp>(
+  return mlir::LLVM::CallIntrinsicOp::create(rewriter,
       loc, resultTy, intrinsicNameAttr, operands);
 }