Skip to content

Commit 6d636ff

Browse files
committed
address reviewer comments
1 parent c3224ad commit 6d636ff

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

mlir/include/mlir/Interfaces/DataLayoutInterfaces.td

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,8 @@ def DataLayoutTypeInterface : TypeInterface<"DataLayoutTypeInterface"> {
657657
"is, that `newLayout` spec entries can be nested in an op with "
658658
"`oldLayout` spec entries. `newSpec` and `identified` are"
659659
"provided to further query data from the combined spec, e.g.,"
660-
"the default address space.",
660+
"the default address space. TODO: Revisit this method once"
661+
"https://github.com/llvm/llvm-project/issues/130321 gets solved",
661662
/*retTy=*/"bool",
662663
/*methodName=*/"areCompatible",
663664
/*args=*/(ins "::mlir::DataLayoutEntryListRef":$oldLayout,

mlir/lib/Dialect/DLTI/DLTI.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,8 @@ combineOneSpec(DataLayoutSpecInterface spec,
340340
"unexpected data layout entry for built-in type");
341341

342342
auto interface = cast<DataLayoutTypeInterface>(typeSample);
343-
// TODO: Revisit this method and call once issue #130321 gets resolved.
343+
// TODO: Revisit this method and call once
344+
// https://github.com/llvm/llvm-project/issues/130321 gets resolved.
344345
if (!interface.areCompatible(entriesForType.lookup(kvp.first), kvp.second,
345346
spec, entriesForID))
346347
return failure();

0 commit comments

Comments
 (0)