Based on PR reviews, improve code quality by making sure const correctness and modifying code format

Co-authored-by: Piotr Zegar <[email protected]>

Author: Andrewyuan34

clang-tools-extra/clang-tidy/utils/UseRangesCheck.cpp

@@ -216,14 +216,13 @@ void UseRangesCheck::check(const MatchFinder::MatchResult &Result) {
     if (!Call)
       continue;
     if (Function->getName() == "find") {
-      unsigned ValueArgIndex = 2;
+      const unsigned ValueArgIndex = 2;
       if (Call->getNumArgs() <= ValueArgIndex)
         continue;
       const Expr *ValueExpr =
           Call->getArg(ValueArgIndex)->IgnoreParenImpCasts();
-      if (isa<CXXNullPtrLiteralExpr>(ValueExpr)) {
+      if (isa<CXXNullPtrLiteralExpr>(ValueExpr))
         return;
-      }
     }
     auto Diag = createDiag(*Call);
     if (auto ReplaceName = Replacer->getReplaceName(*Function))

clang-tools-extra/docs/ReleaseNotes.rst

@@ -109,6 +109,9 @@ Changes in existing checks
 - Improved :doc:`misc-redundant-expression
   <clang-tidy/checks/misc/redundant-expression>` check by providing additional
   examples and fixing some macro related false positives.
+  
+- Fixed a false positive in :doc:`modernize-use-ranges
+  <clang-tidy/checks/modernize/use-ranges>`updat the logic to suppress warnings for `nullptr` in `std::find`.
 
 Removed checks
 ^^^^^^^^^^^^^^

clang-tools-extra/test/clang-tidy/checkers/modernize/use-ranges.cpp

@@ -11,13 +11,14 @@
 
 void Positives() {
   std::vector<int> I, J;
+  std::vector<std::unique_ptr<int>> K;
 
   // Expect to have no check messages
-  std::find(I.begin(), I.end(), nullptr);
+  std::find(K.begin(), K.end(), nullptr);
 
-  std::find(I.begin(), I.end(), std::unique_ptr<int>());
+  std::find(K.begin(), K.end(), std::unique_ptr<int>());
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
-  // CHECK-FIXES: std::ranges::find(I, std::unique_ptr<int>());
+  // CHECK-FIXES: std::ranges::find(K, std::unique_ptr<int>());
 
   std::find(I.begin(), I.end(), 0);
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
@@ -86,13 +87,14 @@ void Positives() {
 
 void Reverse(){
   std::vector<int> I, J;
+  std::vector<std::unique_ptr<int>> K;
 
   // Expect to have no check messages
-  std::find(I.rbegin(), I.rend(), nullptr);
+  std::find(K.rbegin(), K.rend(), nullptr);
 
-  std::find(I.rbegin(), I.rend(), std::unique_ptr<int>());
+  std::find(K.rbegin(), K.rend(), std::unique_ptr<int>());
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
-  // CHECK-FIXES: std::ranges::find(std::ranges::reverse_view(I), std::unique_ptr<int>());
+  // CHECK-FIXES: std::ranges::find(std::ranges::reverse_view(K), std::unique_ptr<int>());
 
   std::find(I.rbegin(), I.rend(), 0);
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
@@ -130,4 +132,3 @@ void Negatives() {
   // Pathological, but probably shouldn't diagnose this
   std::rotate(I.begin(), I.end(), I.end() + 0);
 }
-