[MLIR][WASM] Implement review remarks

Author: Luc Forget

mlir/include/mlir/Target/Wasm/WasmBinaryEncoding.h

@@ -4,19 +4,20 @@
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
-// Define encodings for WebAssembly instructions, types, etc from the
+// Define various flags used to encode instructions, types, etc. in
 // WebAssembly binary format.
 //
-// Each encoding is defined in the WebAssembly binary specification.
+// These encodings are defined in the WebAssembly binary format specification.
 //
 //===----------------------------------------------------------------------===//
 #ifndef MLIR_TARGET_WASMBINARYENCODING
 #define MLIR_TARGET_WASMBINARYENCODING
 
 #include <cstddef>
+
 namespace mlir {
 struct WasmBinaryEncoding {
-  /// Byte encodings for WASM instructions.
+  /// Byte encodings for Wasm instructions.
   struct OpCode {
     // Locals, globals, constants.
     static constexpr std::byte constI32{0x41};
@@ -25,7 +26,7 @@ struct WasmBinaryEncoding {
     static constexpr std::byte constFP64{0x44};
   };
 
-  /// Byte encodings of types in WASM binaries
+  /// Byte encodings of types in Wasm binaries
   struct Type {
     static constexpr std::byte emptyBlockType{0x40};
     static constexpr std::byte funcType{0x60};
@@ -38,15 +39,15 @@ struct WasmBinaryEncoding {
     static constexpr std::byte i32{0x7F};
   };
 
-  /// Byte encodings of WASM imports.
+  /// Byte encodings of Wasm imports.
   struct Import {
     static constexpr std::byte typeID{0x00};
     static constexpr std::byte tableType{0x01};
     static constexpr std::byte memType{0x02};
     static constexpr std::byte globalType{0x03};
   };
 
-  /// Byte encodings for WASM limits.
+  /// Byte encodings for Wasm limits.
   struct LimitHeader {
     static constexpr std::byte lowLimitOnly{0x00};
     static constexpr std::byte bothLimits{0x01};
@@ -58,7 +59,7 @@ struct WasmBinaryEncoding {
     static constexpr std::byte isMutable{0x01};
   };
 
-  /// Byte encodings describing WASM exports.
+  /// Byte encodings describing Wasm exports.
   struct Export {
     static constexpr std::byte function{0x00};
     static constexpr std::byte table{0x01};

mlir/lib/Target/Wasm/TranslateFromWasm.cpp

@@ -5,6 +5,11 @@
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
+//
+// This file implements the WebAssembly importer.
+//
+//===----------------------------------------------------------------------===//
+
 #include "mlir/Dialect/WasmSSA/IR/WasmSSA.h"
 #include "mlir/IR/Attributes.h"
 #include "mlir/IR/Builders.h"
@@ -19,6 +24,7 @@
 #include "llvm/Support/FormatVariadic.h"
 #include "llvm/Support/LEB128.h"
 
+#include <climits>
 #include <cstdint>
 #include <variant>
 
@@ -648,7 +654,7 @@ void ValueStack::dump() const {
   // end of the vector. Iterate in reverse so that the first thing we print
   // is the top of the stack.
   size_t stackSize = size();
-  for (size_t idx = 0; idx < stackSize;) {
+  for (size_t idx = 0; idx < stackSize; idx++) {
     size_t actualIdx = stackSize - 1 - idx;
     llvm::dbgs() << "  ";
     values[actualIdx].dump();