remove duplicates by marking operands not written-to

Author: j2kun

mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp

@@ -1059,7 +1059,7 @@ struct ConcatOpInterface
 
   bool bufferizesToMemoryWrite(Operation *op, OpOperand &opOperand,
                                const AnalysisState &state) const {
-    return true;
+    return false;
   }
 
   bool bufferizesToMemoryRead(Operation *op, OpOperand &opOperand,
@@ -1069,7 +1069,7 @@ struct ConcatOpInterface
 
   AliasingValueList getAliasingValues(Operation *op, OpOperand &opOperand,
                                       const AnalysisState &state) const {
-    return {{op->getResult(0), BufferRelation::Equivalent}};
+    return {};
   }
 
   LogicalResult bufferize(Operation *op, RewriterBase &rewriter,
@@ -1109,7 +1109,7 @@ struct ConcatOpInterface
       sizes.push_back(rewriter.getIndexAttr(dimSize));
     }
 
-    int concatDimOffset = 0;
+    int64_t concatDimOffset = 0;
     for (auto operand : concatOp.getInputs()) {
       // Get the buffer for the operand.
       FailureOr<Value> srcBuffer = getBuffer(rewriter, operand, options);

mlir/test/Dialect/Tensor/bufferize.mlir

@@ -618,13 +618,11 @@ func.func @tensor.splat(%f: f32) -> tensor<10x2x4xf32> {
 // CHECK-LABEL:   func @tensor.concat(
 // CHECK-SAME:        %[[F:.*]]: tensor<8xf32>)
 // CHECK:           %[[F_MEMREF:.*]] = bufferization.to_memref %[[F]]
-// CHECK:           memref.copy %[[F_MEMREF]], %[[F_ALLOC:.*]] :
-// CHECK:           memref.copy %[[F_MEMREF]], %[[F_ALLOC_2:.*]] :
 // CHECK:           %[[ALLOC:.*]] = memref.alloc() {{.*}} : memref<16xf32>
 // CHECK:           %[[SUBVIEW1:.*]] = memref.subview %[[ALLOC]][0] [8] [1]
-// CHECK:           memref.copy %[[F_ALLOC]], %[[SUBVIEW1]]
+// CHECK:           memref.copy %[[F_MEMREF]], %[[SUBVIEW1]]
 // CHECK:           %[[SUBVIEW2:.*]] = memref.subview %[[ALLOC]][8] [8] [1]
-// CHECK:           memref.copy %[[F_ALLOC_2]], %[[SUBVIEW2]]
+// CHECK:           memref.copy %[[F_MEMREF]], %[[SUBVIEW2]]
 // CHECK:           %[[RET:.*]] = bufferization.to_tensor %[[ALLOC]]
 // CHECK:           return %[[RET]]
 // CHECK:         }
@@ -640,13 +638,11 @@ func.func @tensor.concat(%f: tensor<8xf32>) -> tensor<16xf32> {
 // CHECK-SAME:        %[[G:.*]]: tensor<8x5xf32>
 // CHECK-DAG:       %[[F_MEMREF:.*]] = bufferization.to_memref %[[F]]
 // CHECK-DAG:       %[[G_MEMREF:.*]] = bufferization.to_memref %[[G]]
-// CHECK:           memref.copy %[[F_MEMREF]], %[[F_ALLOC:.*]] :
-// CHECK:           memref.copy %[[G_MEMREF]], %[[F_ALLOC_2:.*]] :
 // CHECK:           %[[ALLOC:.*]] = memref.alloc() {{.*}} : memref<8x9xf32>
 // CHECK:           %[[SUBVIEW1:.*]] = memref.subview %[[ALLOC]][0, 0] [8, 4] [1, 1]
-// CHECK:           memref.copy %[[F_ALLOC]], %[[SUBVIEW1]]
+// CHECK:           memref.copy %[[F_MEMREF]], %[[SUBVIEW1]]
 // CHECK:           %[[SUBVIEW2:.*]] = memref.subview %[[ALLOC]][0, 4] [8, 5] [1, 1]
-// CHECK:           memref.copy %[[F_ALLOC_2]], %[[SUBVIEW2]]
+// CHECK:           memref.copy %[[G_MEMREF]], %[[SUBVIEW2]]
 // CHECK:           %[[RET:.*]] = bufferization.to_tensor %[[ALLOC]]
 // CHECK:           return %[[RET]]
 // CHECK:         }