upper bound kMaxFrames

Author: makslevental

mlir/lib/Bindings/Python/Globals.h

@@ -134,6 +134,8 @@ class PyGlobals {
 
     bool isUserTracebackFilename(llvm::StringRef file);
 
+    static constexpr size_t kMaxFrames = 512;
+
   private:
     nanobind::ft_mutex mutex;
     bool locTracebackEnabled_ = false;

mlir/lib/Bindings/Python/IRCore.cpp

@@ -2786,18 +2786,16 @@ class PyOpAttributeMap {
   PyOperationRef operation;
 };
 
-constexpr size_t kMaxFrames = 512;
-
 MlirLocation tracebackToLocation(MlirContext ctx) {
   size_t framesLimit =
       PyGlobals::get().getTracebackLoc().locTracebackFramesLimit();
   // Use a thread_local here to avoid requiring a large amount of space.
-  thread_local std::array<MlirLocation, kMaxFrames> frames;
+  thread_local std::array<MlirLocation, PyGlobals::TracebackLoc::kMaxFrames>
+      frames;
   size_t count = 0;
 
   nb::gil_scoped_acquire acquire;
   PyThreadState *tstate = PyThreadState_GET();
-
   PyFrameObject *next;
   PyFrameObject *pyFrame = PyThreadState_GetFrame(tstate);
   for (; pyFrame != nullptr && count < framesLimit;

mlir/lib/Bindings/Python/IRModule.cpp

@@ -215,7 +215,7 @@ size_t PyGlobals::TracebackLoc::locTracebackFramesLimit() {
 
 void PyGlobals::TracebackLoc::setLocTracebackFramesLimit(size_t value) {
   nanobind::ft_lock_guard lock(mutex);
-  locTracebackFramesLimit_ = value;
+  locTracebackFramesLimit_ = std::min(value, kMaxFrames);
 }
 
 void PyGlobals::TracebackLoc::registerTracebackFileInclusion(