Skip to content

Commit 71554f9

Browse files
committed
Fix unused param error
1 parent 492b9f1 commit 71554f9

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

libc/src/stdlib/strfromd.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ LLVM_LIBC_FUNCTION(int, strfromd,
2828
if (section.has_conv)
2929
result = internal::strfromfloat_convert<double>(&writer, section);
3030
else
31-
result = writer.write(section.raw_string); // TODO everywhere where writer
32-
// is used, set errno and ret -1
31+
result = writer.write(section.raw_string);
3332

3433
if (result < 0)
3534
return result;

libc/src/time/strftime_core/strftime_main.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ int strftime_main(printf_core::Writer<write_mode> *writer,
3636
return result;
3737
}
3838

39-
// TODO could work similar to printf, retval is size_t in libc outer func
39+
// TODO: return result struct like printf, so that size_t can be returned
4040
return static_cast<int>(writer->get_chars_written());
4141
}
4242

libc/test/src/stdio/fprintf_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ TEST(LlvmLibcFPrintfTest, WriteToFile) {
9393

9494
TEST(LlvmLibcFPrintfTest, CharsWrittenOverflow) {
9595
struct NoopStream {};
96-
auto noop_write = [](void *cookie, const char *buf, size_t size) -> ssize_t {
96+
auto noop_write = [](void *, const char *, size_t size) -> ssize_t {
9797
return size;
9898
};
9999

libc/test/src/stdio/vfprintf_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ TEST(LlvmLibcVFPrintfTest, WriteToFile) {
104104

105105
TEST(LlvmLibcVFPrintfTest, CharsWrittenOverflow) {
106106
struct NoopStream {};
107-
auto noop_write = [](void *cookie, const char *buf, size_t size) -> ssize_t {
107+
auto noop_write = [](void *, const char *, size_t size) -> ssize_t {
108108
return size;
109109
};
110110

0 commit comments

Comments
 (0)