Skip to content

Commit 719ae02

Browse files
committed
Fix typos
1 parent 40cf489 commit 719ae02

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

mlir/include/mlir/Conversion/Passes.td

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,8 @@ def SCFToControlFlowPass : Pass<"convert-scf-to-cf"> {
986986
" control flow with a CFG";
987987
let dependentDialects = ["cf::ControlFlowDialect", "LLVM::LLVMDialect"];
988988

989-
let options = [Option<"enableVectorizeHits", "enable-vectorize-hits", "bool",
989+
let options = [Option<"enableVectorizeHints", "enable-vectorize-hints",
990+
"bool",
990991
/*default=*/"false",
991992
"Add vectorization hints when convert SCF parallel "
992993
"loop to ControlFlow dialect">];

mlir/include/mlir/Conversion/SCFToControlFlow/SCFToControlFlow.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class RewritePatternSet;
2121
/// Collect a set of patterns to convert SCF operations to CFG branch-based
2222
/// operations within the ControlFlow dialect.
2323
void populateSCFToControlFlowConversionPatterns(
24-
RewritePatternSet &patterns, bool enableVectorizeHits = false);
24+
RewritePatternSet &patterns, bool enableVectorizeHints = false);
2525

2626
} // namespace mlir
2727

mlir/lib/Conversion/SCFToControlFlow/SCFToControlFlow.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -213,10 +213,10 @@ struct ExecuteRegionLowering : public OpRewritePattern<ExecuteRegionOp> {
213213
struct ParallelLowering : public OpRewritePattern<mlir::scf::ParallelOp> {
214214
using OpRewritePattern<mlir::scf::ParallelOp>::OpRewritePattern;
215215

216-
bool enableVectorizeHits;
216+
bool enableVectorizeHints;
217217

218-
ParallelLowering(mlir::MLIRContext *ctx, bool enableVectorizeHits)
219-
: OpRewritePattern(ctx), enableVectorizeHits(enableVectorizeHits) {}
218+
ParallelLowering(mlir::MLIRContext *ctx, bool enableVectorizeHints)
219+
: OpRewritePattern(ctx), enableVectorizeHints(enableVectorizeHints) {}
220220

221221
LogicalResult matchAndRewrite(mlir::scf::ParallelOp parallelOp,
222222
PatternRewriter &rewriter) const override;
@@ -495,7 +495,7 @@ ParallelLowering::matchAndRewrite(ParallelOp parallelOp,
495495

496496
auto vecAttr = LLVM::LoopVectorizeAttr::get(
497497
rewriter.getContext(),
498-
/* disable */ rewriter.getBoolAttr(false), {}, {}, {}, {}, {}, {});
498+
/*disable=*/rewriter.getBoolAttr(false), {}, {}, {}, {}, {}, {});
499499
auto loopAnnotation = LLVM::LoopAnnotationAttr::get(
500500
rewriter.getContext(), {}, /*vectorize=*/vecAttr, {}, {}, {}, {}, {}, {},
501501
{}, {}, {}, {}, {}, {}, {});
@@ -530,7 +530,7 @@ ParallelLowering::matchAndRewrite(ParallelOp parallelOp,
530530
rewriter.create<scf::YieldOp>(loc, forOp.getResults());
531531
}
532532

533-
if (enableVectorizeHits)
533+
if (enableVectorizeHints)
534534
forOp->setAttr(LLVM::BrOp::getLoopAnnotationAttrName(OperationName(
535535
LLVM::BrOp::getOperationName(), getContext())),
536536
loopAnnotation);
@@ -724,18 +724,18 @@ LogicalResult ForallLowering::matchAndRewrite(ForallOp forallOp,
724724
}
725725

726726
void mlir::populateSCFToControlFlowConversionPatterns(
727-
RewritePatternSet &patterns, bool enableVectorizeHits) {
727+
RewritePatternSet &patterns, bool enableVectorizeHints) {
728728
patterns.add<ForallLowering, ForLowering, IfLowering, WhileLowering,
729729
ExecuteRegionLowering, IndexSwitchLowering>(
730730
patterns.getContext());
731-
patterns.add<ParallelLowering>(patterns.getContext(), enableVectorizeHits);
731+
patterns.add<ParallelLowering>(patterns.getContext(), enableVectorizeHints);
732732
patterns.add<DoWhileLowering>(patterns.getContext(), /*benefit=*/2);
733733
}
734734

735735
void SCFToControlFlowPass::runOnOperation() {
736736
RewritePatternSet patterns(&getContext());
737737
populateSCFToControlFlowConversionPatterns(patterns,
738-
enableVectorizeHits.getValue());
738+
enableVectorizeHints.getValue());
739739

740740
// Configure conversion to lower out SCF operations.
741741
ConversionTarget target(getContext());

mlir/test/Conversion/SCFToControlFlow/convert-to-cfg.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: mlir-opt -allow-unregistered-dialect -convert-scf-to-cf -split-input-file %s | FileCheck %s --check-prefixes=CHECK,NO-VEC
2-
// RUN: mlir-opt -allow-unregistered-dialect -convert-scf-to-cf="enable-vectorize-hits=true" \
2+
// RUN: mlir-opt -allow-unregistered-dialect -convert-scf-to-cf="enable-vectorize-hints=true" \
33
// RUN: -split-input-file %s | FileCheck %s --check-prefixes=CHECK,VEC
44

55
// VEC: #loop_vectorize = #llvm.loop_vectorize<disable = false>

0 commit comments

Comments
 (0)