Some review comments

Author: SLTozer

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py

@@ -192,7 +192,9 @@ def verify_all_breakpoints_hit(self, breakpoint_ids, timeout=DEFAULT_TIMEOUT):
                 if "hitBreakpointIds" not in body:
                     continue
                 hit_bps = body["hitBreakpointIds"]
-                if all(int(breakpoint_id) in hit_bps for breakpoint_id in breakpoint_ids):
+                if all(
+                    int(breakpoint_id) in hit_bps for breakpoint_id in breakpoint_ids
+                ):
                     return
         self.assertTrue(False, f"breakpoints not hit, stopped_events={stopped_events}")
 

lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_setBreakpoints.py

@@ -405,7 +405,7 @@ def test_hit_multiple_breakpoints(self):
         all appear in the stop reason."""
         breakpoint_lines = [
             line_number("main.cpp", "// end of foo check"),
-            line_number("main.cpp", "// before loop")
+            line_number("main.cpp", "// before loop"),
         ]
 
         program = self.getBuildArtifact("a.out")

lldb/tools/lldb-dap/JSONUtils.cpp

@@ -654,13 +654,13 @@ llvm::json::Value CreateThreadStopped(DAP &dap, lldb::SBThread &thread,
       } else {
         body.try_emplace("reason", "breakpoint");
       }
-      std::vector<llvm::json::Value> bp_ids;
+      std::vector<lldb::break_id_t> bp_ids;
       std::ostringstream desc_sstream;
       desc_sstream << "breakpoint";
       for (size_t idx = 0; idx < thread.GetStopReasonDataCount(); idx += 2) {
         lldb::break_id_t bp_id = thread.GetStopReasonDataAtIndex(idx);
         lldb::break_id_t bp_loc_id = thread.GetStopReasonDataAtIndex(idx + 1);
-        bp_ids.push_back(llvm::json::Value(bp_id));
+        bp_ids.push_back(bp_id);
         desc_sstream << " " << bp_id << "." << bp_loc_id;
       }
       std::string desc_str = desc_sstream.str();