Skip to content

Commit 720468f

Browse files
committed
update tests, update unpacking selection condition
1 parent 022fa2d commit 720468f

File tree

2 files changed

+811
-206
lines changed

2 files changed

+811
-206
lines changed

llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,8 @@ bool SIPreEmitPeephole::removeExeczBranch(MachineInstr &MI,
458458
// llvm/test/CodeGen/AMDGPU/unpack-non-coissue-insts-post-ra-scheduler.mir.
459459
bool SIPreEmitPeephole::isUnpackingSupportedInstr(MachineInstr &MI) const {
460460
unsigned Opcode = MI.getOpcode();
461+
if (!TII->isNeverCoissue(MI))
462+
return false;
461463
switch (Opcode) {
462464
case AMDGPU::V_PK_ADD_F32:
463465
case AMDGPU::V_PK_MUL_F32:
@@ -642,7 +644,6 @@ void SIPreEmitPeephole::collectUnpackingCandidates(
642644
if (!isUnpackingSupportedInstr(Instr))
643645
continue;
644646

645-
assert(TII->isNeverCoissue(Instr) && "Instruction cannot be co-issued.");
646647
if (canUnpackingClobberRegister(Instr))
647648
return;
648649
// If it's a packed instruction, adjust latency: remove the packed

0 commit comments

Comments
 (0)