Skip to content

Commit 7243489

Browse files
committed
Address review comments.
1 parent 6719743 commit 7243489

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

clang/lib/Frontend/FrontendAction.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ namespace {
6767
/// compiler frontend have been deserialized. In case our processing causes
6868
/// further deserialization, DeclRead from the listener might be called again.
6969
/// However, at that point we don't accept any more Decls for processing.
70-
class DeserializedDeclsLineRangePrinter : public ASTConsumer,
71-
ASTDeserializationListener {
70+
class DeserializedDeclsSourceRangePrinter : public ASTConsumer,
71+
ASTDeserializationListener {
7272
public:
73-
explicit DeserializedDeclsLineRangePrinter(
73+
explicit DeserializedDeclsSourceRangePrinter(
7474
SourceManager &SM, std::unique_ptr<llvm::raw_fd_ostream> OS)
7575
: ASTDeserializationListener(), SM(SM), OS(std::move(OS)) {}
7676

@@ -144,7 +144,7 @@ class DeserializedDeclsLineRangePrinter : public ASTConsumer,
144144
std::vector<std::pair<Position, Position>> FromTo;
145145
OptionalFileEntryRef Ref;
146146
};
147-
llvm::DenseMap<const FileEntry *, FileData> FileToLines;
147+
llvm::DenseMap<const FileEntry *, FileData> FileToRanges;
148148
for (const Decl *D : PendingDecls) {
149149
CharSourceRange R = SM.getExpansionRange(D->getSourceRange());
150150
if (!R.isValid())
@@ -156,7 +156,7 @@ class DeserializedDeclsLineRangePrinter : public ASTConsumer,
156156
continue;
157157
}
158158

159-
auto &Data = FileToLines[F];
159+
auto &Data = FileToRanges[F];
160160
if (!Data.Ref)
161161
Data.Ref = SM.getFileEntryRefForID(SM.getFileID(R.getBegin()));
162162
Data.FromTo.push_back(
@@ -166,7 +166,7 @@ class DeserializedDeclsLineRangePrinter : public ASTConsumer,
166166

167167
// To simplify output, merge consecutive and intersecting ranges.
168168
std::vector<RequiredRanges> Result;
169-
for (auto &[F, Data] : FileToLines) {
169+
for (auto &[F, Data] : FileToRanges) {
170170
auto &FromTo = Data.FromTo;
171171
assert(!FromTo.empty());
172172

@@ -314,11 +314,11 @@ FrontendAction::CreateWrappedASTConsumer(CompilerInstance &CI,
314314
DumpDeserializedDeclarationRangesPath, ErrorCode,
315315
llvm::sys::fs::OF_None);
316316
if (!ErrorCode) {
317-
Consumers.push_back(std::make_unique<DeserializedDeclsLineRangePrinter>(
317+
Consumers.push_back(std::make_unique<DeserializedDeclsSourceRangePrinter>(
318318
CI.getSourceManager(), std::move(FileStream)));
319319
} else {
320320
llvm::errs() << "Failed to create output file for "
321-
"-dump-deserialized-declaration-ranges flag, file path: "
321+
"-dump-minimization-hints flag, file path: "
322322
<< DumpDeserializedDeclarationRangesPath
323323
<< ", error: " << ErrorCode.message() << "\n";
324324
}

0 commit comments

Comments
 (0)