test and review fixup

Author: balazske

clang-tools-extra/docs/clang-tidy/checks/bugprone/cast-to-struct.rst

@@ -50,5 +50,5 @@ Options
    and casts from ``short *`` to ``struct T1 *`` (the `*` character needs to be
    escaped). The type name in the cast expression is matched without resolution
    of ``typedef`` types.
-   
-   Default value of the option is an empty list.
+
+   Default value of the option is an empty string.

clang-tools-extra/test/clang-tidy/checkers/bugprone/cast-to-struct.c

@@ -28,11 +28,11 @@ typedef int * int_ptr_t;
 
 struct S1 *test_simple(short *p) {
   return (struct S1 *)p;
-  // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: casting a 'short *' pointer to a 'struct S1 *' pointer and accessing a field can lead to memory access errors or data corruption [bugprone-cast-to-struct]
+  // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: casting a 'short *' pointer to a 'struct S1 *' pointer can lead to memory access errors or data corruption [bugprone-cast-to-struct]
   struct S1 *s;
   int i;
   s = (struct S1 *)&i;
-  // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: casting a 'int *' pointer to a 'struct S1 *' pointer and accessing a field can lead to memory access errors or data corruption [bugprone-cast-to-struct]
+  // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: casting a 'int *' pointer to a 'struct S1 *' pointer can lead to memory access errors or data corruption [bugprone-cast-to-struct]
 }
 
 struct S1 *test_cast_from_void(void *p) {
@@ -41,7 +41,7 @@ struct S1 *test_cast_from_void(void *p) {
 
 struct S1 *test_cast_from_struct(struct S2 *p) {
   return (struct S1 *)p;
-  // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: casting a 'struct S2 *' pointer to a 'struct S1 *' pointer and accessing a field can lead to memory access errors or data corruption [bugprone-cast-to-struct]
+  // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: casting a 'struct S2 *' pointer to a 'struct S1 *' pointer can lead to memory access errors or data corruption [bugprone-cast-to-struct]
 }
 
 TyPS1 test_cast_from_similar(struct S1 *p) {
@@ -50,13 +50,13 @@ TyPS1 test_cast_from_similar(struct S1 *p) {
 
 void test_typedef(short *p1, int_t *p2, int_ptr_t p3) {
   TyS1 *a = (TyS1 *)p1;
-  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: casting a 'short *' pointer to a 'TyS1 *' (aka 'struct S1 *') pointer and accessing a field can lead to memory access errors or data corruption [bugprone-cast-to-struct]
+  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: casting a 'short *' pointer to a 'TyS1 *' (aka 'struct S1 *') pointer can lead to memory access errors or data corruption [bugprone-cast-to-struct]
   TyPS1 b = (TyPS1)p1;
-  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: casting a 'short *' pointer to a 'TyPS1' (aka 'struct S1 *') pointer and accessing a field can lead to memory access errors or data corruption [bugprone-cast-to-struct]
+  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: casting a 'short *' pointer to a 'TyPS1' (aka 'struct S1 *') pointer can lead to memory access errors or data corruption [bugprone-cast-to-struct]
   struct S1 *c = (struct S1 *)p2;
-  // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: casting a 'int_t *' (aka 'int *') pointer to a 'struct S1 *' pointer and accessing a field can lead to memory access errors or data corruption [bugprone-cast-to-struct]
+  // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: casting a 'int_t *' (aka 'int *') pointer to a 'struct S1 *' pointer can lead to memory access errors or data corruption [bugprone-cast-to-struct]
   struct S1 *d = (struct S1 *)p3;
-  // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: casting a 'int_ptr_t' (aka 'int *') pointer to a 'struct S1 *' pointer and accessing a field can lead to memory access errors or data corruption [bugprone-cast-to-struct]
+  // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: casting a 'int_ptr_t' (aka 'int *') pointer to a 'struct S1 *' pointer can lead to memory access errors or data corruption [bugprone-cast-to-struct]
 }
 
 void test_union(short *p1, union U1 *p2, TyPU1 p3) {