Tidying up and removing irrelevant comments

Author: ojhunt

clang/lib/CodeGen/CGExprCXX.cpp

@@ -1394,8 +1394,6 @@ static UsualDeleteParams getUsualDeleteParams(const FunctionDecl *FD) {
   auto AI = FPT->param_type_begin(), AE = FPT->param_type_end();
 
   if (FD->isTypeAwareOperatorNewOrDelete()) {
-    // Assume Sema has ensured a non-pointer first parameter is
-    // a type identity.
     Params.TypeAwareDelete = TypeAwareAllocationMode::Yes;
     assert(AI != AE);
     ++AI;

clang/lib/Sema/SemaCoroutine.cpp

@@ -1433,8 +1433,7 @@ bool CoroutineStmtBuilder::makeNewAndDeleteExpr() {
         // scope of the promise type.
         // - If any declarations are found, ...
         // - If no declarations are found in the scope of the promise type, a
-        // search is performed in the global scope or via ADL for typed
-        // allocation.
+        //   search is performed in the global scope.
         if (NewScope == Sema::AFS_Both)
           NewScope = PromiseContainsNew ? Sema::AFS_Class : Sema::AFS_Global;
 

clang/lib/Sema/SemaDecl.cpp

@@ -17466,19 +17466,6 @@ Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind TUK, SourceLocation KWLoc,
     Previous.clear();
   }
 
-  // I think DC check should be DC->isStdNamespace()?
-  // Also these guards are questionable - it's possible to get incorrect
-  // codegen when the declared type does not match the expected type.
-  // e.g. something like
-  //    namespace std { struct align_val_t { explicit align_val_t(size_t); } };
-  // can result in an operator new/delete decl picking up this specified
-  // align_val_t struct, but the align_val_t constructed implicitly has the
-  // mismatching internal definition.
-  //
-  // The correct course of action is probably to perform this logic at the point
-  // a declaration is inserted into the DeclContext, where it can also perform
-  // appropriate type checks for warnings/errors, rather than working backwards
-  // from the assumption that the type will always be correct.
   if (getLangOpts().CPlusPlus && Name && DC && StdNamespace &&
       DC->Equals(getStdNamespace())) {
     if (Name->isStr("bad_alloc")) {

clang/lib/Sema/SemaDeclCXX.cpp

@@ -10865,9 +10865,8 @@ bool Sema::CheckDestructor(CXXDestructorDecl *Destructor) {
       // first parameter, perform that conversion now.
       if (OperatorDelete->isDestroyingOperatorDelete()) {
         unsigned PointerParam = 0;
-        if (isTypeAwareOperatorNewOrDelete(OperatorDelete)) {
+        if (isTypeAwareOperatorNewOrDelete(OperatorDelete))
           ++PointerParam;
-        }
         QualType ParamType =
             OperatorDelete->getParamDecl(PointerParam)->getType();
         if (!declaresSameEntity(ParamType->getAsCXXRecordDecl(), RD)) {

clang/lib/Sema/SemaExprCXX.cpp

@@ -2749,7 +2749,8 @@ static bool resolveAllocationOverloadInterior(
                                                /*AlignArg=*/nullptr, Diagnose);
     }
     if (Mode == ResolveMode::Typed) {
-      // If we can't find a matching typed we don't consider this a failure.
+      // If we can't find a matching type aware operator we don't consider this a
+      // failure.
       Operator = nullptr;
       return false;
     }