Skip to content

Commit 72b8dbc

Browse files
author
joaosaffran
committed
addressing comments
1 parent 750a6d5 commit 72b8dbc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

llvm/test/CodeGen/DirectX/ContainerData/RootSignature-DescriptorTable.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ attributes #0 = { "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" }
1616
!2 = !{ ptr @main, !3 } ; function, root signature
1717
!3 = !{ !5 } ; list of root signature elements
1818
!5 = !{ !"DescriptorTable", i32 0, !6, !7 }
19-
!6 = !{ !"SRV", i32 0, i32 0, i32 -1, i32 -1, i32 4 }
19+
!6 = !{ !"SRV", i32 0, i32 1, i32 0, i32 -1, i32 4 }
2020
!7 = !{ !"UAV", i32 5, i32 1, i32 10, i32 5, i32 2 }
2121

2222
; DXC: - Name: RTS0
@@ -36,8 +36,8 @@ attributes #0 = { "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" }
3636
; DXC-NEXT: Ranges:
3737
; DXC-NEXT: - RangeType: 0
3838
; DXC-NEXT: NumDescriptors: 0
39-
; DXC-NEXT: BaseShaderRegister: 0
40-
; DXC-NEXT: RegisterSpace: 4294967295
39+
; DXC-NEXT: BaseShaderRegister: 1
40+
; DXC-NEXT: RegisterSpace: 0
4141
; DXC-NEXT: OffsetInDescriptorsFromTableStart: 4294967295
4242
; DXC-NEXT: DATA_VOLATILE: true
4343
; DXC-NEXT: - RangeType: 1

llvm/test/CodeGen/DirectX/ContainerData/RootSignature-Parameters.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ attributes #0 = { "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" }
1717
!5 = !{ !"RootConstants", i32 0, i32 1, i32 2, i32 3 }
1818
!6 = !{ !"RootSRV", i32 1, i32 4, i32 5, i32 6 }
1919
!7 = !{ !"DescriptorTable", i32 0, !8, !9 }
20-
!8 = !{ !"SRV", i32 0, i32 0, i32 -1, i32 -1, i32 4 }
20+
!8 = !{ !"SRV", i32 0, i32 1, i32 0, i32 -1, i32 4 }
2121
!9 = !{ !"UAV", i32 5, i32 1, i32 10, i32 5, i32 2 }
2222

2323
;CHECK-LABEL: Definition for 'main':
@@ -39,8 +39,8 @@ attributes #0 = { "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" }
3939
;CHECK-NEXT: Shader Visibility: 0
4040
;CHECK-NEXT: NumRanges: 2
4141
;CHECK-NEXT: - Range Type: 0
42-
;CHECK-NEXT: Register Space: 4294967295
43-
;CHECK-NEXT: Base Shader Register: 0
42+
;CHECK-NEXT: Register Space: 0
43+
;CHECK-NEXT: Base Shader Register: 1
4444
;CHECK-NEXT: Num Descriptors: 0
4545
;CHECK-NEXT: Offset In Descriptors From Table Start: 4294967295
4646
;CHECK-NEXT: Flags: 4

0 commit comments

Comments
 (0)