Skip to content

Commit 73910bd

Browse files
committed
Drop non-actionable FIXME, capitalize variable
1 parent ab0e1a5 commit 73910bd

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

clang/lib/StaticAnalyzer/Checkers/AssumeModeling.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ void AssumeModelingChecker::checkPostStmt(const AttributedStmt *A,
5454

5555
bool AssumeModelingChecker::evalCall(const CallEvent &Call,
5656
CheckerContext &C) const {
57-
ProgramStateRef state = C.getState();
57+
ProgramStateRef State = C.getState();
5858
const auto *FD = dyn_cast_or_null<FunctionDecl>(Call.getDecl());
5959
if (!FD)
6060
return false;
@@ -69,15 +69,13 @@ bool AssumeModelingChecker::evalCall(const CallEvent &Call,
6969
if (Arg.isUndef())
7070
return true; // Return true to model purity.
7171

72-
state = state->assume(Arg.castAs<DefinedOrUnknownSVal>(), true);
73-
// FIXME: do we want to warn here? Not right now. The most reports might
74-
// come from infeasible paths, thus being false positives.
75-
if (!state) {
72+
State = State->assume(Arg.castAs<DefinedOrUnknownSVal>(), true);
73+
if (!State) {
7674
C.addSink();
7775
return true;
7876
}
7977

80-
C.addTransition(state);
78+
C.addTransition(State);
8179
return true;
8280
}
8381

0 commit comments

Comments
 (0)