Addressing PR comments

dhernandez0 · dhernandez0 · commit 739274b7d330 · 2025-02-28T08:33:21.000Z
diff --git a/mlir/lib/Dialect/AMDGPU/Transforms/EmulateAtomics.cpp b/mlir/lib/Dialect/AMDGPU/Transforms/EmulateAtomics.cpp
@@ -189,6 +189,8 @@ void mlir::amdgpu::populateAmdgpuEmulateAtomicsPatterns(
     } else {
       target.addIllegalOp<RawBufferAtomicFmaxOp>();
     }
+    // TODO: refactor this to avoid hardcoding ISA version:
+    // https://github.com/llvm/llvm-project/issues/129206
     // gfx950 has bf16 atomics
     if (chipset < Chipset(9, 5, 0)) {
       target.addDynamicallyLegalOp<RawBufferAtomicFaddOp>(

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,8 @@ void mlir::amdgpu::populateAmdgpuEmulateAtomicsPatterns(`
`189`	`189`	`} else {`
`190`	`190`	`target.addIllegalOp<RawBufferAtomicFmaxOp>();`
`191`	`191`	`}`
	`192`	`+ // TODO: refactor this to avoid hardcoding ISA version:`
	`193`	`+ // https://github.com/llvm/llvm-project/issues/129206`
`192`	`194`	`// gfx950 has bf16 atomics`
`193`	`195`	`if (chipset < Chipset(9, 5, 0)) {`
`194`	`196`	`target.addDynamicallyLegalOp<RawBufferAtomicFaddOp>(`