Skip to content

Commit 7407769

Browse files
committed
review comments fix
1 parent c68b4d9 commit 7407769

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

llvm/test/DebugInfo/symbolize-big-archive-elf.test

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
// Test archive member recognition by name (ELF format)
1+
// Test archive member recognition by name (ELF format).
22

3-
// Generate object files from YAML
3+
// Generate object files from YAML.
44
// RUN: yaml2obj -o %t-1.o %S/Inputs/big-archive-elf-1.yaml
55
// RUN: yaml2obj -o %t-2.o %S/Inputs/big-archive-elf-2.yaml
66

7-
// Create archive with differently named members
7+
// Create archive with differently named members.
88
// RUN: rm -f %t.a
99
// RUN: llvm-ar crv %t.a %t-1.o %t-2.o
1010

11-
// Test symbolization by member name (using just base names)
11+
// Test symbolization by member name (using just base names).
1212
// RUN: llvm-symbolizer --default-arch=ppc64le --obj="%t.a(%{t:stem}.tmp-1.o)" 0x0 | FileCheck %s --check-prefix=CHECK-1
1313
// RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp-1.o):ppc64le" 0x0 | FileCheck %s --check-prefix=CHECK-1
1414
// RUN: llvm-symbolizer --default-arch=ppc64le --obj="%t.a(%{t:stem}.tmp-2.o)" 0x0 | FileCheck %s --check-prefix=CHECK-2
1515
// RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp-2.o):ppc64le" 0x0 | FileCheck %s --check-prefix=CHECK-2
1616
// CHECK-1: foo1
1717
// CHECK-2: foo2
1818

19-
// Test error cases
19+
// Test error cases.
2020
// RUN: not llvm-symbolizer --obj="%t.a(nonexistent.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR
2121
// CHECK-ERROR: error: {{.*}}no matching member{{.*}}
2222
// RUN: not llvm-symbolizer --obj="%t-1.o(%{t:stem}.tmp-1.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-NOTARCHIVE

llvm/test/DebugInfo/symbolize-big-archive-xcoff.test

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
1-
// Test big archive recognition and error handling in llvm-symbolizer
1+
// Test big archive recognition and error handling in llvm-symbolizer.
22

3-
// Generate object files
3+
// Generate object files.
44
// RUN: yaml2obj -o %t-32.o %S/Inputs/big-archive-32.yaml
55
// RUN: yaml2obj -o %t-64.o %S/Inputs/big-archive-64.yaml
66

7-
// Create archive with same-named members using different modes
7+
// Create archive with same-named members using different modes.
88
// RUN: rm -f %t.a
99
// RUN: cp %t-32.o %t.o
1010
// RUN: llvm-ar %if system-aix %{-X32%} crv %t.a %t.o
1111
// RUN: cp %t-64.o %t.o
1212
// RUN: llvm-ar %if system-aix %{-X64 rv%} %else %{qv%} %t.a %t.o
1313

14-
// Verify archive contains two members with same name
14+
// Verify archive contains two members with same name.
1515
// RUN: llvm-ar tv %if system-aix %{-X32_64%} %t.a | FileCheck %s --check-prefix=CHECK-ARCHIVE
1616
// CHECK-ARCHIVE: {{.*}}symbolize-big-archive-xcoff.test.tmp.o{{$}}
1717
// CHECK-ARCHIVE: {{.*}}symbolize-big-archive-xcoff.test.tmp.o{{$}}
1818

19-
// Test successful symbolization
19+
// Test successful symbolization.
2020
// RUN: llvm-symbolizer --default-arch=ppc --obj="%t.a(%{t:stem}.tmp.o)" 0x0 | FileCheck %s --check-prefix=CHECK-32
2121
// RUN: llvm-symbolizer --default-arch=ppc64 --obj="%t.a(%{t:stem}.tmp.o)" 0x0 | FileCheck %s --check-prefix=CHECK-64
2222
// RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp.o):ppc" 0x0 | FileCheck %s --check-prefix=CHECK-32
2323
// RUN: llvm-symbolizer --obj="%t.a(%{t:stem}.tmp.o):ppc64" 0x0 | FileCheck %s --check-prefix=CHECK-64
2424
// CHECK-32: foo
2525
// CHECK-64: foo
2626

27-
// Test error cases
27+
// Test error cases.
2828
// RUN: not llvm-symbolizer --obj="%t.a(nonexistent.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR
2929
// CHECK-ERROR: error: {{.*}}no matching member{{.*}}
3030
// RUN: not llvm-symbolizer --obj="%t.o(%{t:stem}.tmp.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-NOTARCHIVE

0 commit comments

Comments
 (0)