update pr, test branch against bot

Author: wldfngrs

libc/config/linux/x86_64/entrypoints.txt

@@ -667,7 +667,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
     libc.src.math.scalblnf16
     libc.src.math.scalbnf16
     libc.src.math.setpayloadf16
-    libc.src.math.setpayloadsigf16 
+    libc.src.math.setpayloadsigf16
     libc.src.math.sinpif16
     libc.src.math.totalorderf16
     libc.src.math.totalordermagf16

libc/src/math/generic/sinpif16.cpp

@@ -110,8 +110,7 @@ LLVM_LIBC_FUNCTION(float16, sinpif16, (float16 x)) {
   float ysq = y * y;
 
   // Degree-6 minimax even polynomial for sin(y*pi/32)/y generated by Sollya
-  // with:
-  // > Q = fpminimax(sin(y*pi/32)/y, [|0, 2, 4, 6|], [|SG...|], [0, 0.5]);
+  // with: > Q = fpminimax(sin(y*pi/32)/y, [|0, 2, 4, 6|], [|SG...|], [0, 0.5]);
   float sin_y = y * fputil::polyeval(ysq, 0x1.921fb6p-4f, -0x1.4aeabcp-13f,
                                      0x1.a03354p-21f, -0x1.ad02d2p-20f);
 
@@ -120,8 +119,7 @@ LLVM_LIBC_FUNCTION(float16, sinpif16, (float16 x)) {
   // sin(x * pi) = sin((k + y) * pi/32)
   //             = sin_y * cos_k + cos_y * sin_k
   //             = cos_k * sin_y + sin_k * (1 + cos_y - 1)
-  // Degree-6 minimax even polynomial for cos(y*pi/32)
-  // generated by Sollya with:
+  // Degree-6 minimax even polynomial for cos(y*pi/32) generated by Sollya with:
   // > P = fpminimax(cos(y*pi/32), [|0, 2, 4, 6|],[|1, SG...|], [0, 0.5]);
   float cosm1_y = ysq * fputil::polyeval(ysq, -0x1.3bd3ccp-8f, 0x1.03a61ap-18f,
                                          0x1.a6f7a2p-29f);

libc/test/src/math/sinpif16_test.cpp

@@ -1,4 +1,5 @@
-//===-- Exhaustive test for sinpif16---------------------------------------===//
+//===-- Exhaustive test for sinpif16
+//---------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -27,14 +28,14 @@ TEST_F(LlvmLibcSinpif16Test, PositiveRange) {
   for (uint16_t v = POS_START; v <= POS_STOP; ++v) {
     float16 x = FPBits(v).get_val();
     EXPECT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Sinpi, x,
-                                   LIBC_NAMESPACE::sinpif16(x), 1);
+                                   LIBC_NAMESPACE::sinpif16(x), 0.5);
   }
 }
 
 TEST_F(LlvmLibcSinpif16Test, NegativeRange) {
   for (uint16_t v = NEG_START; v <= NEG_STOP; ++v) {
     float16 x = FPBits(v).get_val();
     EXPECT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Sinpi, x,
-                                   LIBC_NAMESPACE::sinpif16(x), 1);
+                                   LIBC_NAMESPACE::sinpif16(x), 0.5);
   }
 }

libc/test/src/math/smoke/sinpif16_test.cpp

@@ -4,7 +4,6 @@
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
-//
 // ===----------------------------------------------------------------------==//
 
 #include "src/errno/libc_errno.h"
@@ -20,10 +19,10 @@ TEST_F(LlvmLibcSinpif16Test, SpecialNumbers) {
   EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::sinpif16(aNaN));
   EXPECT_MATH_ERRNO(0);
 
-  EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::sinpif16(0.0f));
+  EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(0.0f));
   EXPECT_MATH_ERRNO(0);
 
-  EXPECT_FP_EQ(-0.0f, LIBC_NAMESPACE::sinpif16(-0.0f));
+  EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(-0.0f));
   EXPECT_MATH_ERRNO(0);
 
   EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::sinpif16(inf));
@@ -34,10 +33,10 @@ TEST_F(LlvmLibcSinpif16Test, SpecialNumbers) {
 }
 
 TEST_F(LlvmLibcSinpif16Test, Integers) {
-  EXPECT_FP_EQ(-0.0, LIBC_NAMESPACE::sinpif16(-0x420));
-  EXPECT_FP_EQ(-0.0, LIBC_NAMESPACE::sinpif16(-0x1p+10));
-  EXPECT_FP_EQ(-0.0, LIBC_NAMESPACE::sinpif16(-0x1.4p+14));
-  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::sinpif16(0x420));
-  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::sinpif16(0x1.cp+15));
-  EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::sinpif16(0x1.cp+7));
+  EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(-0x420));
+  EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(-0x1p+10));
+  EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(-0x1.4p+14));
+  EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(0x420));
+  EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(0x1.cp+15));
+  EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(0x1.cp+7));
 }

libc/utils/MPFRWrapper/MPFRUtils.cpp

@@ -498,7 +498,7 @@ class MPFRNumber {
     MPFRNumber value_mul_two(*this);
     mpfr_mul_si(value_mul_two.value, value, 2, MPFR_RNDN);
 
-    if (mpfr_integer_p(value_mul_two.value) != 0) {
+    if (mpfr_integer_p(value_mul_two.value)) {
       auto d = mpfr_get_si(value, MPFR_RNDD);
       mpfr_set_si(result.value, (d & 1) ? -1 : 1, mpfr_rounding);
       return result;