Skip to content

Commit 74c5de1

Browse files
kovdan01kovdan01
committed
[PAC][clang] Handle pauthtest environment and ABI in Linux-specific code
Since pauthtest is a Linux-specific ABI, it should not be handled in common driver code.
1 parent 838b0d0 commit 74c5de1

File tree

13 files changed

+150
-102
lines changed

13 files changed

+150
-102
lines changed

‎clang/lib/Basic/Targets/AArch64.cpp‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,7 @@ AArch64TargetInfo::AArch64TargetInfo(const llvm::Triple &Triple,
206206
StringRef AArch64TargetInfo::getABI() const { return ABI; }
207207

208208
bool AArch64TargetInfo::setABI(const std::string &Name) {
209-
if (Name != "aapcs" && Name != "aapcs-soft" && Name != "darwinpcs" &&
210-
Name != "pauthtest")
209+
if (Name != "aapcs" && Name != "aapcs-soft" && Name != "darwinpcs")
211210
return false;
212211

213212
ABI = Name;
@@ -221,12 +220,6 @@ bool AArch64TargetInfo::validateTarget(DiagnosticsEngine &Diags) const {
221220
Diags.Report(diag::err_target_unsupported_abi_with_fpu) << ABI;
222221
return false;
223222
}
224-
if (getTriple().getEnvironment() == llvm::Triple::PAuthTest &&
225-
getTriple().getOS() != llvm::Triple::Linux) {
226-
Diags.Report(diag::err_target_unsupported_abi_for_triple)
227-
<< getTriple().getEnvironmentName() << getTriple().getTriple();
228-
return false;
229-
}
230223
return true;
231224
}
232225

‎clang/lib/Basic/Targets/AArch64.h‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ class LLVM_LIBRARY_VISIBILITY AArch64TargetInfo : public TargetInfo {
121121

122122
const llvm::AArch64::ArchInfo *ArchInfo = &llvm::AArch64::ARMV8A;
123123

124+
protected:
124125
std::string ABI;
125126

126127
public:
@@ -258,6 +259,16 @@ class LLVM_LIBRARY_VISIBILITY AArch64leTargetInfo : public AArch64TargetInfo {
258259
void setDataLayout() override;
259260
};
260261

262+
template <>
263+
inline bool
264+
LinuxTargetInfo<AArch64leTargetInfo>::setABI(const std::string &Name) {
265+
if (Name == "pauthtest") {
266+
ABI = Name;
267+
return true;
268+
}
269+
return AArch64leTargetInfo::setABI(Name);
270+
}
271+
261272
class LLVM_LIBRARY_VISIBILITY WindowsARM64TargetInfo
262273
: public WindowsTargetInfo<AArch64leTargetInfo> {
263274
const llvm::Triple Triple;

‎clang/lib/Basic/Targets/OSTargets.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
//===----------------------------------------------------------------------===//
1111

1212
#include "OSTargets.h"
13+
#include "AArch64.h"
1314
#include "clang/Basic/MacroBuilder.h"
1415
#include "llvm/ADT/StringRef.h"
1516

‎clang/lib/Basic/Targets/OSTargets.h‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,12 @@ class LLVM_LIBRARY_VISIBILITY LinuxTargetInfo : public OSTargetInfo<Target> {
374374
const char *getStaticInitSectionSpecifier() const override {
375375
return ".text.startup";
376376
}
377+
378+
// This allows template specializations, see
379+
// LinuxTargetInfo<AArch64leTargetInfo>::setABI
380+
bool setABI(const std::string &Name) override {
381+
return OSTargetInfo<Target>::setABI(Name);
382+
}
377383
};
378384

379385
// NetBSD Target

‎clang/lib/CodeGen/CodeGenModule.cpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,6 @@ createTargetCodeGenInfo(CodeGenModule &CGM) {
144144
return createWindowsAArch64TargetCodeGenInfo(CGM, AArch64ABIKind::Win64);
145145
else if (Target.getABI() == "aapcs-soft")
146146
Kind = AArch64ABIKind::AAPCSSoft;
147-
else if (Target.getABI() == "pauthtest")
148-
Kind = AArch64ABIKind::PAuthTest;
149147

150148
return createAArch64TargetCodeGenInfo(CGM, Kind);
151149
}

‎clang/lib/CodeGen/TargetInfo.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,6 @@ enum class AArch64ABIKind {
469469
DarwinPCS,
470470
Win64,
471471
AAPCSSoft,
472-
PAuthTest,
473472
};
474473

475474
std::unique_ptr<TargetCodeGenInfo>

‎clang/lib/Driver/ToolChain.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1110,7 +1110,6 @@ std::string ToolChain::ComputeLLVMTriple(const ArgList &Args,
11101110
}
11111111
case llvm::Triple::aarch64: {
11121112
llvm::Triple Triple = getTriple();
1113-
tools::aarch64::setPAuthABIInTriple(getDriver(), Args, Triple);
11141113
if (!Triple.isOSBinFormatMachO())
11151114
return Triple.getTriple();
11161115

‎clang/lib/Driver/ToolChains/Arch/AArch64.cpp‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -455,24 +455,3 @@ void aarch64::getAArch64TargetFeatures(const Driver &D,
455455
if (Args.getLastArg(options::OPT_mno_bti_at_return_twice))
456456
Features.push_back("+no-bti-at-return-twice");
457457
}
458-
459-
void aarch64::setPAuthABIInTriple(const Driver &D, const ArgList &Args,
460-
llvm::Triple &Triple) {
461-
Arg *ABIArg = Args.getLastArg(options::OPT_mabi_EQ);
462-
bool HasPAuthABI =
463-
ABIArg ? (StringRef(ABIArg->getValue()) == "pauthtest") : false;
464-
465-
switch (Triple.getEnvironment()) {
466-
case llvm::Triple::UnknownEnvironment:
467-
if (HasPAuthABI)
468-
Triple.setEnvironment(llvm::Triple::PAuthTest);
469-
break;
470-
case llvm::Triple::PAuthTest:
471-
break;
472-
default:
473-
if (HasPAuthABI)
474-
D.Diag(diag::err_drv_unsupported_opt_for_target)
475-
<< ABIArg->getAsString(Args) << Triple.getTriple();
476-
break;
477-
}
478-
}

‎clang/lib/Driver/ToolChains/Arch/AArch64.h‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ void getAArch64TargetFeatures(const Driver &D, const llvm::Triple &Triple,
2828
std::string getAArch64TargetCPU(const llvm::opt::ArgList &Args,
2929
const llvm::Triple &Triple, llvm::opt::Arg *&A);
3030

31-
void setPAuthABIInTriple(const Driver &D, const llvm::opt::ArgList &Args,
32-
llvm::Triple &triple);
33-
3431
} // end namespace aarch64
3532
} // end namespace target
3633
} // end namespace driver

‎clang/lib/Driver/ToolChains/Clang.cpp‎

Lines changed: 3 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1501,59 +1501,6 @@ void AddUnalignedAccessWarning(ArgStringList &CmdArgs) {
15011501
}
15021502
}
15031503

1504-
// Each combination of options here forms a signing schema, and in most cases
1505-
// each signing schema is its own incompatible ABI. The default values of the
1506-
// options represent the default signing schema.
1507-
static void handlePAuthABI(const ArgList &DriverArgs, ArgStringList &CC1Args) {
1508-
if (!DriverArgs.hasArg(options::OPT_fptrauth_intrinsics,
1509-
options::OPT_fno_ptrauth_intrinsics))
1510-
CC1Args.push_back("-fptrauth-intrinsics");
1511-
1512-
if (!DriverArgs.hasArg(options::OPT_fptrauth_calls,
1513-
options::OPT_fno_ptrauth_calls))
1514-
CC1Args.push_back("-fptrauth-calls");
1515-
1516-
if (!DriverArgs.hasArg(options::OPT_fptrauth_returns,
1517-
options::OPT_fno_ptrauth_returns))
1518-
CC1Args.push_back("-fptrauth-returns");
1519-
1520-
if (!DriverArgs.hasArg(options::OPT_fptrauth_auth_traps,
1521-
options::OPT_fno_ptrauth_auth_traps))
1522-
CC1Args.push_back("-fptrauth-auth-traps");
1523-
1524-
if (!DriverArgs.hasArg(
1525-
options::OPT_fptrauth_vtable_pointer_address_discrimination,
1526-
options::OPT_fno_ptrauth_vtable_pointer_address_discrimination))
1527-
CC1Args.push_back("-fptrauth-vtable-pointer-address-discrimination");
1528-
1529-
if (!DriverArgs.hasArg(
1530-
options::OPT_fptrauth_vtable_pointer_type_discrimination,
1531-
options::OPT_fno_ptrauth_vtable_pointer_type_discrimination))
1532-
CC1Args.push_back("-fptrauth-vtable-pointer-type-discrimination");
1533-
1534-
if (!DriverArgs.hasArg(
1535-
options::OPT_fptrauth_type_info_vtable_pointer_discrimination,
1536-
options::OPT_fno_ptrauth_type_info_vtable_pointer_discrimination))
1537-
CC1Args.push_back("-fptrauth-type-info-vtable-pointer-discrimination");
1538-
1539-
if (!DriverArgs.hasArg(options::OPT_fptrauth_indirect_gotos,
1540-
options::OPT_fno_ptrauth_indirect_gotos))
1541-
CC1Args.push_back("-fptrauth-indirect-gotos");
1542-
1543-
if (!DriverArgs.hasArg(options::OPT_fptrauth_init_fini,
1544-
options::OPT_fno_ptrauth_init_fini))
1545-
CC1Args.push_back("-fptrauth-init-fini");
1546-
1547-
if (!DriverArgs.hasArg(
1548-
options::OPT_fptrauth_init_fini_address_discrimination,
1549-
options::OPT_fno_ptrauth_init_fini_address_discrimination))
1550-
CC1Args.push_back("-fptrauth-init-fini-address-discrimination");
1551-
1552-
if (!DriverArgs.hasArg(options::OPT_faarch64_jump_table_hardening,
1553-
options::OPT_fno_aarch64_jump_table_hardening))
1554-
CC1Args.push_back("-faarch64-jump-table-hardening");
1555-
}
1556-
15571504
static void CollectARMPACBTIOptions(const ToolChain &TC, const ArgList &Args,
15581505
ArgStringList &CmdArgs, bool isAArch64) {
15591506
const Arg *A = isAArch64
@@ -1783,7 +1730,9 @@ void RenderAArch64ABI(const llvm::Triple &Triple, const ArgList &Args,
17831730
ABIName = A->getValue();
17841731
else if (Triple.isOSDarwin())
17851732
ABIName = "darwinpcs";
1786-
else if (Triple.getEnvironment() == llvm::Triple::PAuthTest)
1733+
// TODO: we probably want to have some target hook here.
1734+
else if (Triple.isOSLinux() &&
1735+
Triple.getEnvironment() == llvm::Triple::PAuthTest)
17871736
ABIName = "pauthtest";
17881737
else
17891738
ABIName = "aapcs";
@@ -1821,9 +1770,6 @@ void Clang::AddAArch64TargetArgs(const ArgList &Args,
18211770
// Enable/disable return address signing and indirect branch targets.
18221771
CollectARMPACBTIOptions(getToolChain(), Args, CmdArgs, true /*isAArch64*/);
18231772

1824-
if (Triple.getEnvironment() == llvm::Triple::PAuthTest)
1825-
handlePAuthABI(Args, CmdArgs);
1826-
18271773
// Handle -msve_vector_bits=<bits>
18281774
if (Arg *A = Args.getLastArg(options::OPT_msve_vector_bits_EQ)) {
18291775
StringRef Val = A->getValue();

0 commit comments

Comments
 (0)