use config command instead of env var

Author: makslevental

mlir/test/CMakeLists.txt

@@ -65,6 +65,12 @@ if (MLIR_INCLUDE_INTEGRATION_TESTS)
 
 endif()
 
+option(MLIR_RUN_STANDALONE_INSTALL_TESTS "Run Standalone example install tests." ON)
+if(MLIR_RUN_STANDALONE_INSTALL_TESTS AND "${CMAKE_INSTALL_PREFIX}" STREQUAL "")
+  message(WARNING "Standalone example install tests will install into root!\
+  If you want to disable this behavior pass -DMLIR_RUN_STANDALONE_INSTALL_TESTS=OFF")
+endif()
+
 llvm_canonicalize_cmake_booleans(
   LLVM_BUILD_EXAMPLES
   LLVM_HAS_NVPTX_TARGET
@@ -76,6 +82,7 @@ llvm_canonicalize_cmake_booleans(
   MLIR_ENABLE_SPIRV_CPU_RUNNER
   MLIR_ENABLE_VULKAN_RUNNER
   MLIR_INCLUDE_INTEGRATION_TESTS
+  MLIR_RUN_STANDALONE_INSTALL_TESTS
   MLIR_RUN_AMX_TESTS
   MLIR_RUN_CUDA_TENSOR_CORE_TESTS
   MLIR_RUN_X86VECTOR_TESTS

mlir/test/Examples/standalone/lit.local.cfg

@@ -18,10 +18,12 @@ config.substitutions.append(("%cmake_build_type", config.cmake_build_type))
 config.substitutions.append(("%cmake_c_compiler_launcher", config.cmake_c_compiler_launcher))
 config.substitutions.append(("%cmake_cxx_compiler_launcher", config.cmake_cxx_compiler_launcher))
 
-# see https://github.com/llvm/llvm-project/blob/57782eff31e9d454b54a201c7ac43dc1b93dbb3f/llvm/utils/lit/lit/TestRunner.py#L1858
-config.substitutions.insert(0, ("FileCheck", "FileChuck"))
-config.substitutions.insert(0, ("count", "kount"))
-config.substitutions.insert(0, ("not", "mot"))
-config.substitutions.append(("kount", "count"))
-config.substitutions.append(("mot", "not"))
-config.substitutions.append(("FileChuck", "FileCheck"))
+if config.run_standalone_install_tests:
+    config.available_features.add("run-standalone-install-tests")
+    # see https://github.com/llvm/llvm-project/blob/57782eff31e9d454b54a201c7ac43dc1b93dbb3f/llvm/utils/lit/lit/TestRunner.py#L1858
+    config.substitutions.insert(0, ("FileCheck", "FileChuck"))
+    config.substitutions.insert(0, ("count", "kount"))
+    config.substitutions.insert(0, ("not", "mot"))
+    config.substitutions.append(("kount", "count"))
+    config.substitutions.append(("mot", "not"))
+    config.substitutions.append(("FileChuck", "FileCheck"))

mlir/test/Examples/standalone/test.install-dir.toy

@@ -1,4 +1,4 @@
-# REQUIRES: github-actions
+# REQUIRES: run-standalone-install-tests
 
 # RUN: echo "test full install" | tee %t
 # CHECK: test full install

mlir/test/lit.cfg.py

@@ -383,6 +383,3 @@ def have_host_jit_feature_support(feature_name):
 
 if sys.version_info >= (3, 11):
     config.available_features.add("python-ge-311")
-
-if "GITHUB_ACTIONS" in os.environ:
-    config.available_features.add("github-actions")

mlir/test/lit.site.cfg.py.in

@@ -37,6 +37,7 @@ config.build_examples = @LLVM_BUILD_EXAMPLES@
 config.run_nvptx_tests = @LLVM_HAS_NVPTX_TARGET@
 config.enable_cuda_runner = @MLIR_ENABLE_CUDA_RUNNER@
 config.run_rocm_tests = @MLIR_ENABLE_ROCM_CONVERSIONS@
+config.run_standalone_install_tests = @MLIR_RUN_STANDALONE_INSTALL_TESTS@
 config.enable_rocm_runner = @MLIR_ENABLE_ROCM_RUNNER@
 config.gpu_compilation_format = "@MLIR_GPU_COMPILATION_TEST_FORMAT@"
 config.rocm_test_chipset = "@ROCM_TEST_CHIPSET@"