Skip to content

Commit 74f2fa2

Browse files
committed
[libc++] Remove a few incorrect _LIBCPP_EXPORTED_FROM_ABI annotations
1 parent 411e61d commit 74f2fa2

File tree

14 files changed

+18
-16
lines changed

14 files changed

+18
-16
lines changed

libcxx/docs/DesignDocs/VisibilityMacros.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ Visibility Macros
3131
Mark a symbol as being part of our ABI. This includes functions that are part
3232
of the libc++ library, type information and other symbols. On Windows,
3333
this macro applies `dllimport`/`dllexport` to the symbol, and on other
34-
platforms it gives the symbol default visibility.
34+
platforms it gives the symbol default visibility. This macro should never be
35+
used on class templates. On classes it should only be used if the vtable
36+
should be in the shared library.
3537

3638
**_LIBCPP_OVERRIDABLE_FUNC_VIS**
3739
Mark a symbol as being exported by the libc++ library, but allow it to be

libcxx/include/__charconv/from_chars_result.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD
2121

2222
#if _LIBCPP_STD_VER >= 17
2323

24-
struct _LIBCPP_EXPORTED_FROM_ABI from_chars_result {
24+
struct from_chars_result {
2525
const char* ptr;
2626
errc ec;
2727
# if _LIBCPP_STD_VER >= 20

libcxx/include/__charconv/to_chars_result.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD
2121

2222
#if _LIBCPP_STD_VER >= 17
2323

24-
struct _LIBCPP_EXPORTED_FROM_ABI to_chars_result {
24+
struct to_chars_result {
2525
char* ptr;
2626
errc ec;
2727
# if _LIBCPP_STD_VER >= 20

libcxx/include/__filesystem/file_status.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
_LIBCPP_BEGIN_NAMESPACE_FILESYSTEM
2424

25-
class _LIBCPP_EXPORTED_FROM_ABI file_status {
25+
class file_status {
2626
public:
2727
// constructors
2828
_LIBCPP_HIDE_FROM_ABI file_status() noexcept : file_status(file_type::none) {}

libcxx/include/__filesystem/path.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -861,7 +861,7 @@ class _LIBCPP_EXPORTED_FROM_ABI path {
861861
}
862862

863863
// iterators
864-
class _LIBCPP_EXPORTED_FROM_ABI iterator;
864+
class iterator;
865865
typedef iterator const_iterator;
866866

867867
iterator begin() const;

libcxx/include/__filesystem/space_info.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
_LIBCPP_BEGIN_NAMESPACE_FILESYSTEM
2323

24-
struct _LIBCPP_EXPORTED_FROM_ABI space_info {
24+
struct space_info {
2525
uintmax_t capacity;
2626
uintmax_t free;
2727
uintmax_t available;

libcxx/include/__format/formatter_output.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD
4545

4646
namespace __formatter {
4747

48-
struct _LIBCPP_EXPORTED_FROM_ABI __padding_size_result {
48+
struct __padding_size_result {
4949
size_t __before_;
5050
size_t __after_;
5151
};

libcxx/include/__memory_resource/pool_options.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ namespace pmr {
2424

2525
// [mem.res.pool.options]
2626

27-
struct _LIBCPP_EXPORTED_FROM_ABI pool_options {
27+
struct pool_options {
2828
size_t max_blocks_per_chunk = 0;
2929
size_t largest_required_pool_block = 0;
3030
};

libcxx/include/__mutex/tag_types.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717

1818
_LIBCPP_BEGIN_NAMESPACE_STD
1919

20-
struct _LIBCPP_EXPORTED_FROM_ABI defer_lock_t {
20+
struct defer_lock_t {
2121
explicit defer_lock_t() = default;
2222
};
2323

24-
struct _LIBCPP_EXPORTED_FROM_ABI try_to_lock_t {
24+
struct try_to_lock_t {
2525
explicit try_to_lock_t() = default;
2626
};
2727

28-
struct _LIBCPP_EXPORTED_FROM_ABI adopt_lock_t {
28+
struct adopt_lock_t {
2929
explicit adopt_lock_t() = default;
3030
};
3131

libcxx/include/__new/nothrow_t.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
# include <new.h>
2020
#else
2121
_LIBCPP_BEGIN_UNVERSIONED_NAMESPACE_STD
22-
struct _LIBCPP_EXPORTED_FROM_ABI nothrow_t {
22+
struct nothrow_t {
2323
explicit nothrow_t() = default;
2424
};
2525
extern _LIBCPP_EXPORTED_FROM_ABI const nothrow_t nothrow;

0 commit comments

Comments
 (0)