Skip to content

Commit 75b812e

Browse files
authored
[Dexter] Update Dexter lit substitutions, making lldb-dap the default (#155838)
This patch updates Dexter's lit test setup, making lldb-dap the default debugger where available; as part of this, I've replaced references to `--debugger lldb` with new substitutions that provide the debugger and executable path: one substitution returns just lldb for the tests that require it (all the LLDB-using tests in `dexter-tests`), and the other which provides the system-preferred debugger for the tests that should be able to run with any debugger (all the tests in `feature_tests`). As a small note, one test generates output that differs between lldb and lldb-dap - for this test specifically, we add an lldb-dap feature so that it can be marked XFAIL if we fall back to using LLDB.
1 parent 0d9c0ce commit 75b812e

40 files changed

+68
-100
lines changed

cross-project-tests/debuginfo-tests/dexter-tests/aggregate-indirect-arg.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
//
44
// RUN: %clang++ -std=gnu++11 -O0 -g %s -o %t
55
// RUN: %dexter --fail-lt 1.0 -w \
6-
// RUN: --binary %t --debugger 'lldb' -- %s
6+
// RUN: --binary %t %dexter_lldb_args -- %s
77
// Radar 8945514
88

99
class SVal {

cross-project-tests/debuginfo-tests/dexter-tests/asan-deque.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
// RUN: %clang++ -std=gnu++11 -O1 -glldb -fsanitize=address -arch x86_64 %s -o %t
1212
// RUN: %dexter --fail-lt 1.0 -w \
13-
// RUN: --binary %t --debugger 'lldb' -- %s
13+
// RUN: --binary %t %dexter_lldb_args -- %s
1414
#include <deque>
1515

1616
struct A {

cross-project-tests/debuginfo-tests/dexter-tests/asan.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// RUN: %clang -std=gnu11 --driver-mode=gcc -O0 -glldb -fblocks -arch x86_64 \
77
// RUN: -fsanitize=address %s -o %t
88
// RUN: %dexter --fail-lt 1.0 -w \
9-
// RUN: --binary %t --debugger 'lldb' -- %s
9+
// RUN: --binary %t %dexter_lldb_args -- %s
1010

1111
struct S {
1212
int a[8];

cross-project-tests/debuginfo-tests/dexter-tests/ctor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
//
44
// RUN: %clang++ -std=gnu++11 -O0 -glldb %s -o %t
55
// RUN: %dexter --fail-lt 1.0 -w \
6-
// RUN: --binary %t --debugger 'lldb' -- %s
6+
// RUN: --binary %t %dexter_lldb_args -- %s
77

88
class A {
99
public:

cross-project-tests/debuginfo-tests/dexter-tests/dbg-arg.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// This test case checks debug info during register moves for an argument.
55
// RUN: %clang -std=gnu11 -m64 -mllvm -fast-isel=false -g %s -o %t
66
// RUN: %dexter --fail-lt 1.0 -w \
7-
// RUN: --binary %t --debugger 'lldb' -- %s
7+
// RUN: --binary %t %dexter_lldb_args -- %s
88
//
99
// Radar 8412415
1010

cross-project-tests/debuginfo-tests/dexter-tests/deferred_globals.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// UNSUPPORTED: system-windows
77
// RUN: %clang++ -std=gnu++11 -O0 -g %s -o %t
88
// RUN: %dexter --fail-lt 1.0 -w \
9-
// RUN: --binary %t --debugger 'lldb' -v -- %s
9+
// RUN: --binary %t %dexter_lldb_args -v -- %s
1010

1111
const int d = 100;
1212

cross-project-tests/debuginfo-tests/dexter-tests/memvars/bitcast.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// REQUIRES: lldb
55
// UNSUPPORTED: system-windows
66
// RUN: %clang -std=gnu11 -O3 -glldb %s -o %t
7-
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
7+
// RUN: %dexter --fail-lt 1.0 -w %dexter_lldb_args --binary %t -- %s
88

99
//// Adapted from https://bugs.llvm.org/show_bug.cgi?id=34136#c1
1010
//// LowerDbgDeclare has since been updated to look through bitcasts. We still

cross-project-tests/debuginfo-tests/dexter-tests/memvars/const-branch.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// REQUIRES: lldb
55
// UNSUPPORTED: system-windows
66
// RUN: %clang -std=gnu11 -O3 -glldb %s -o %t
7-
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
7+
// RUN: %dexter --fail-lt 1.0 -w %dexter_lldb_args --binary %t -- %s
88

99
//// Adapted from https://bugs.llvm.org/show_bug.cgi?id=34136#c4
1010

cross-project-tests/debuginfo-tests/dexter-tests/memvars/ctrl-flow.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: lldb
22
// UNSUPPORTED: system-windows
33
// RUN: %clang -std=gnu11 -O2 -glldb %s -o %t
4-
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
4+
// RUN: %dexter --fail-lt 1.0 -w %dexter_lldb_args --binary %t -- %s
55

66
//// Check that we give good locations to a variable ('local') which is escaped
77
//// down some control paths and not others. This example is handled well currently.

cross-project-tests/debuginfo-tests/dexter-tests/memvars/implicit-ptr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// REQUIRES: lldb
55
// UNSUPPORTED: system-windows
66
// RUN: %clang -std=gnu11 -O3 -glldb %s -o %t
7-
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
7+
// RUN: %dexter --fail-lt 1.0 -w %dexter_lldb_args --binary %t -- %s
88

99
//// Check that 'param' in 'fun' can be read throughout, and that 'pa' and 'pb'
1010
//// can be dereferenced in the debugger even if we can't provide the pointer

0 commit comments

Comments
 (0)