Skip to content

Commit 7695d2f

Browse files
committed
improve comment
1 parent 6f0135b commit 7695d2f

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

clang/lib/CodeGen/CGExpr.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5985,13 +5985,13 @@ LValue CodeGenFunction::EmitBinaryOperatorLValue(const BinaryOperator *E) {
59855985

59865986
assert(E->getOpcode() == BO_Assign && "unexpected binary l-value");
59875987

5988-
// This covers both LHS and RHS expressions, though nested RHS
5989-
// expressions may get subsequently separately grouped.
5990-
// FIXME(OCH): Not clear yet if we've got fine enough control
5991-
// to pick and choose when we need to. Currently looks ok:
5992-
// a = b = c -> Two atoms.
5993-
// x = new(1) -> One atom (for both addr store and value store).
5994-
// Complex and agg assignment -> One atom.
5988+
// Create a Key Instructions source location atom group that covers both
5989+
// LHS and RHS expressions. Nested RHS expressions may get subsequently
5990+
// separately grouped (1 below):
5991+
//
5992+
// 1. `a = b = c` -> Two atoms.
5993+
// 2. `x = new(1)` -> One atom (for both addr store and value store).
5994+
// 3. Complex and agg assignment -> One atom.
59955995
ApplyAtomGroup Grp(getDebugInfo());
59965996

59975997
// Note that in all of these cases, __block variables need the RHS

0 commit comments

Comments
 (0)