[clang][Sema] NormalizedConstraint - fix MSVC "not all control paths return a value" warnings. NFC. (#162004)

RKSimon · web-flow · commit 76cff3bcdbe9 · 2025-10-05T11:16:31.000Z
diff --git a/clang/include/clang/Sema/SemaConcept.h b/clang/include/clang/Sema/SemaConcept.h
@@ -257,6 +257,7 @@ struct NormalizedConstraint {
     case ConstraintKind::FoldExpanded:
       return FoldExpanded.Pattern->getBeginLoc();
     }
+    llvm_unreachable("Unknown ConstraintKind enum");
   }
 
   SourceLocation getEndLoc() const {
@@ -270,6 +271,7 @@ struct NormalizedConstraint {
     case ConstraintKind::FoldExpanded:
       return FoldExpanded.Pattern->getEndLoc();
     }
+    llvm_unreachable("Unknown ConstraintKind enum");
   }
 
   SourceRange getSourceRange() const { return {getBeginLoc(), getEndLoc()}; }

Original file line number	Diff line number	Diff line change
`@@ -257,6 +257,7 @@ struct NormalizedConstraint {`
`257`	`257`	`case ConstraintKind::FoldExpanded:`
`258`	`258`	`return FoldExpanded.Pattern->getBeginLoc();`
`259`	`259`	`}`
	`260`	`+ llvm_unreachable("Unknown ConstraintKind enum");`
`260`	`261`	`}`
`261`	`262`
`262`	`263`	`SourceLocation getEndLoc() const {`
`@@ -270,6 +271,7 @@ struct NormalizedConstraint {`
`270`	`271`	`case ConstraintKind::FoldExpanded:`
`271`	`272`	`return FoldExpanded.Pattern->getEndLoc();`
`272`	`273`	`}`
	`274`	`+ llvm_unreachable("Unknown ConstraintKind enum");`
`273`	`275`	`}`
`274`	`276`
`275`	`277`	`SourceRange getSourceRange() const { return {getBeginLoc(), getEndLoc()}; }`