Skip to content

Commit 76e4eb6

Browse files
committed
(1) Removed target generation check (2) Added comment.
1 parent 897cc8f commit 76e4eb6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -803,8 +803,10 @@ DecodeStatus AMDGPUDisassembler::getInstruction(MCInst &MI, uint64_t &Size,
803803
if (ImmLitIdx != -1 && !IsSOPK)
804804
convertFMAanyK(MI, ImmLitIdx);
805805

806-
if (isGFX10Plus() &&
807-
(MCII->get(MI.getOpcode()).TSFlags & SIInstrFlags::VOP3) &&
806+
// Some VOPC instructions, e.g., v_cmpx_f_f64, use VOP3 encoding and
807+
// have EXEC as implicit destination. Issue a warning if encoding for
808+
// vdst is not EXEC.
809+
if ((MCII->get(MI.getOpcode()).TSFlags & SIInstrFlags::VOP3) &&
808810
MCII->get(MI.getOpcode()).hasImplicitDefOfPhysReg(AMDGPU::EXEC)) {
809811
auto ExecEncoding = MRI.getEncodingValue(AMDGPU::EXEC_LO);
810812
if (Bytes_[0] != ExecEncoding)

0 commit comments

Comments
 (0)