Skip to content

Commit 76e71e0

Browse files
[NFC][clang] Prefer triple overload of lookupTarget (#162185)
The string overload will be deprecated soon, similar to other functions in TargetRegistry.
1 parent 1553802 commit 76e71e0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

clang/lib/Testing/CommandLineArgs.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ std::string getAnyTargetForTesting() {
103103
StringRef TargetName(Target.getName());
104104
if (TargetName == "x86-64")
105105
TargetName = "x86_64";
106-
if (llvm::TargetRegistry::lookupTarget(TargetName, Error) == &Target) {
106+
if (llvm::TargetRegistry::lookupTarget(llvm::Triple(TargetName), Error) ==
107+
&Target) {
107108
return std::string(TargetName);
108109
}
109110
}

clang/unittests/Driver/ToolChainTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ TEST(ToolChainTest, ParsedClangName) {
442442
TEST(ToolChainTest, GetTargetAndMode) {
443443
llvm::InitializeAllTargets();
444444
std::string IgnoredError;
445-
if (!llvm::TargetRegistry::lookupTarget("x86_64", IgnoredError))
445+
if (!llvm::TargetRegistry::lookupTarget(llvm::Triple("x86_64"), IgnoredError))
446446
GTEST_SKIP();
447447

448448
ParsedClangName Res = ToolChain::getTargetAndModeFromProgramName("clang");

0 commit comments

Comments
 (0)