cr feedback - remove include, update error messages

Author: hekota

clang/lib/AST/ASTContext.cpp

@@ -3438,7 +3438,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx,
     return;
   }
   case Type::HLSLAttributedResource:
-    llvm_unreachable("not yet implemented");
+    llvm_unreachable("should never get here");
     break;
   case Type::DeducedTemplateSpecialization:
   case Type::Auto:
@@ -13386,6 +13386,7 @@ static QualType getCommonNonSugarTypeNode(ASTContext &Ctx, const Type *X,
     SUGAR_FREE_TYPE(Record)
     SUGAR_FREE_TYPE(SubstTemplateTypeParmPack)
     SUGAR_FREE_TYPE(UnresolvedUsing)
+    SUGAR_FREE_TYPE(HLSLAttributedResource)
 #undef SUGAR_FREE_TYPE
 #define NON_UNIQUE_TYPE(Class) UNEXPECTED_TYPE(Class, "non-unique")
     NON_UNIQUE_TYPE(TypeOfExpr)
@@ -13690,9 +13691,6 @@ static QualType getCommonNonSugarTypeNode(ASTContext &Ctx, const Type *X,
         TX->getDepth(), TX->getIndex(), TX->isParameterPack(),
         getCommonDecl(TX->getDecl(), TY->getDecl()));
   }
-  case Type::HLSLAttributedResource: {
-    llvm_unreachable("not yet implemented");
-  }
   }
   llvm_unreachable("Unknown Type Class");
 }

clang/lib/AST/MicrosoftMangle.cpp

@@ -32,7 +32,6 @@
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/Support/CRC.h"
-#include "llvm/Support/DXILABI.h"
 #include "llvm/Support/MD5.h"
 #include "llvm/Support/MathExtras.h"
 #include "llvm/Support/StringSaver.h"

clang/lib/CodeGen/ItaniumCXXABI.cpp

@@ -3945,7 +3945,7 @@ void ItaniumRTTIBuilder::BuildVTablePointer(const Type *Ty) {
     break;
 
   case Type::HLSLAttributedResource:
-    llvm_unreachable("not yet implemented");
+    llvm_unreachable("HLSL doesn't support virtual functions");
   }
 
   llvm::Constant *VTable = nullptr;
@@ -4210,7 +4210,7 @@ llvm::Constant *ItaniumRTTIBuilder::BuildTypeInfo(
     break;
 
   case Type::HLSLAttributedResource:
-    llvm_unreachable("not yet implemented");
+    llvm_unreachable("HLSL doesn't support RTTI");
   }
 
   llvm::Constant *Init = llvm::ConstantStruct::getAnon(Fields);

clang/lib/CodeGen/Targets/DirectX.cpp

@@ -46,7 +46,7 @@ llvm::Type *DirectXTargetCodeGenInfo::getHLSLType(CodeGenModule &CGM,
     // convert element type
     llvm::Type *ElemType = CGM.getTypes().ConvertType(ContainedTy);
 
-    const char *TypeName =
+    llvm::StringRef TypeName =
         ResAttrs.RawBuffer ? "dx.RawBuffer" : "dx.TypedBuffer";
     SmallVector<unsigned, 3> Ints = {/*IsWriteable*/ ResAttrs.ResourceClass ==
                                          llvm::dxil::ResourceClass::UAV,