Skip to content

Commit 780a3b2

Browse files
committed
Address code review comments
1 parent 7712fc1 commit 780a3b2

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ Improvements to Clang's diagnostics
214214
:doc:`ThreadSafetyAnalysis` still does not perform alias analysis. The
215215
feature will be default-enabled with ``-Wthread-safety`` in a future release.
216216

217-
- Improve the diagnostics for shadows template parameter.
217+
- Improve the diagnostics for shadows template parameter to report correct location (#GH129060).
218218

219219
Improvements to Clang's time-trace
220220
----------------------------------

clang/test/CXX/temp/temp.res/temp.local/p6.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ A<0>::B a;
164164
}
165165

166166
template <typename T> void shadow() { // expected-note{{template parameter is declared here}}
167-
using arr = int[1]; // expected-warning@+1 {{decomposition declarations are a C++17 extension}}
167+
using arr = int[1];
168+
// expected-warning@+1 {{decomposition declarations are a C++17 extension}}
168169
auto [
169170
T // expected-error {{declaration of 'T' shadows template parameter}}
170171
] = arr{};

0 commit comments

Comments
 (0)