changed hook function names and few comments

Author: laxmansole

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

@@ -2204,18 +2204,17 @@ void DwarfDebug::beginInstruction(const MachineInstr *MI) {
       Flags |= DWARF2_FLAG_IS_STMT;
   }
 
-  // Call the hook that allows targets to customize source line recording
-  recordSourceLineHook(*MI, DL, Flags);
+  // Call target-specific source line recording.
+  recordTargetSourceLine(*MI, DL, Flags);
 
   // If we're not at line 0, remember this location.
   if (DL.getLine())
     PrevInstLoc = DL;
 }
 
-// Default implementation of target-specific hook for custom source line
-// recording
-void DwarfDebug::recordSourceLineHook(const MachineInstr &MI,
-                                      const DebugLoc &DL, unsigned Flags) {
+// Default implementation of target-specific source line recording.
+void DwarfDebug::recordTargetSourceLine(const MachineInstr &MI,
+                                        const DebugLoc &DL, unsigned Flags) {
   SmallString<128> LocationString;
   if (Asm->OutStreamer->isVerboseAsm()) {
     raw_svector_ostream OS(LocationString);
@@ -2719,8 +2718,8 @@ void DwarfDebug::beginFunctionImpl(const MachineFunction *MF) {
   Asm->OutStreamer->getContext().setDwarfCompileUnitID(
       getDwarfCompileUnitIDForLineTable(CU));
 
-  // Call target-specific hook for custom initialization
-  beginFunctionHook(*MF);
+  // Call target-specific debug info initialization.
+  initializeTargetDebugInfo(*MF);
 
   // Record beginning of function.
   PrologEndLoc = emitInitialLocDirective(

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h

@@ -717,13 +717,13 @@ class DwarfDebug : public DebugHandlerBase {
 
   void skippedNonDebugFunction() override;
 
-  /// Target-specific hook for custom initialization,
-  /// default implementation is empty, only being used for NVPTX target
-  virtual void beginFunctionHook(const MachineFunction &MF) {}
+  /// Target-specific debug info initialization at function start.
+  /// Default implementation is empty, overridden by NVPTX target.
+  virtual void initializeTargetDebugInfo(const MachineFunction &MF) {}
 
-  /// Target-specific hook for custom source line recording
-  virtual void recordSourceLineHook(const MachineInstr &MI, const DebugLoc &DL,
-                                    unsigned Flags);
+  /// Target-specific source line recording.
+  virtual void recordTargetSourceLine(const MachineInstr &MI,
+                                      const DebugLoc &DL, unsigned Flags);
 
   const SmallVectorImpl<std::unique_ptr<DwarfCompileUnit>> &getUnits() {
     return InfoHolder.getUnits();

llvm/lib/Target/NVPTX/NVPTXDwarfDebug.cpp

@@ -151,15 +151,16 @@ void NVPTXDwarfDebug::recordSourceLineAndInlinedAt(const MachineInstr &MI,
   }
 }
 
-// NVPTX-specific function initialization hook.
-void NVPTXDwarfDebug::beginFunctionHook(const MachineFunction &MF) {
+// NVPTX-specific debug info initialization.
+void NVPTXDwarfDebug::initializeTargetDebugInfo(const MachineFunction &MF) {
   InlinedAtLocs.clear();
   collectInlinedAtLocations(MF);
 }
 
 // NVPTX-specific source line recording with inlined_at support.
-void NVPTXDwarfDebug::recordSourceLineHook(const MachineInstr &MI,
-                                           const DebugLoc &DL, unsigned Flags) {
+void NVPTXDwarfDebug::recordTargetSourceLine(const MachineInstr &MI,
+                                             const DebugLoc &DL,
+                                             unsigned Flags) {
   // Call NVPTX-specific implementation that handles inlined_at.
   recordSourceLineAndInlinedAt(MI, Flags);
 }

llvm/lib/Target/NVPTX/NVPTXDwarfDebug.h

@@ -36,11 +36,11 @@ class NVPTXDwarfDebug : public DwarfDebug {
   void collectInlinedAtLocations(const MachineFunction &MF);
 
 protected:
-  /// Override hook to collect inlined_at locations.
-  void beginFunctionHook(const MachineFunction &MF) override;
-  /// Override hook to record source line information with inlined_at support.
-  void recordSourceLineHook(const MachineInstr &MI, const DebugLoc &DL,
-                            unsigned Flags) override;
+  /// Override to collect inlined_at locations.
+  void initializeTargetDebugInfo(const MachineFunction &MF) override;
+  /// Override to record source line information with inlined_at support.
+  void recordTargetSourceLine(const MachineInstr &MI, const DebugLoc &DL,
+                              unsigned Flags) override;
 
 private:
   /// NVPTX-specific source line recording with inlined_at support.