address pr feedback

Author: farzonl

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -12356,7 +12356,7 @@ def err_builtin_invalid_arg_type: Error <
   "an unsigned integer|"
   "an 'int'|"
   "a vector of floating points|"
-  "a vector of integers or floating points}1 (was %2)">;
+  "a vector of arithmetic element type}1 (was %2)">;
 
 def err_builtin_matrix_disabled: Error<
   "matrix types extension is disabled. Pass -fenable-matrix to enable it">;

clang/lib/CodeGen/CGBuiltin.cpp

@@ -4283,7 +4283,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
     if (E->getArg(0)->getType()->hasFloatingRepresentation()) {
       Value *X = EmitScalarExpr(E->getArg(0));
       auto EltTy = X->getType()->getScalarType();
-      Value *Seed = ConstantFP::get(EltTy, 0);
+      Value *Seed = ConstantFP::get(EltTy, -0.0);
       return RValue::get(Builder.CreateIntrinsic(
           /*ReturnType=*/EltTy, llvm::Intrinsic::vector_reduce_fadd,
           ArrayRef<Value *>{Seed, X}, nullptr, "rdx.fadd"));
@@ -4296,7 +4296,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
     if (E->getArg(0)->getType()->hasFloatingRepresentation()) {
       Value *X = EmitScalarExpr(E->getArg(0));
       auto EltTy = X->getType()->getScalarType();
-      Value *Seed = ConstantFP::get(EltTy, 0);
+      Value *Seed = ConstantFP::get(EltTy, 1.0);
       return RValue::get(Builder.CreateIntrinsic(
           /*ReturnType=*/EltTy, llvm::Intrinsic::vector_reduce_fmul,
           ArrayRef<Value *>{Seed, X}, nullptr, "rdx.fmul"));