modularize SemaSPIRV.cpp

Author: raoanag

clang/lib/Headers/hlsl/hlsl_intrinsic_helpers.h

@@ -88,6 +88,7 @@ constexpr vector<T, L> refract_vec_impl(vector<T, L> I, vector<T, L> N, T Eta) {
 #endif
 }
 
+
 template <typename T> constexpr T fmod_impl(T X, T Y) {
 #if !defined(__DIRECTX__)
   return __builtin_elementwise_fmod(X, Y);

clang/lib/Sema/SemaSPIRV.cpp

@@ -230,40 +230,20 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(const TargetInfo &TI,
     if (SemaRef.checkArgCount(TheCall, 3))
       return true;
 
-    ExprResult A = TheCall->getArg(0);
-    QualType ArgTyA = A.get()->getType();
-    auto *VTyA = ArgTyA->getAs<VectorType>();
-    if (VTyA == nullptr) {
-      SemaRef.Diag(A.get()->getBeginLoc(),
-                   diag::err_typecheck_convert_incompatible)
-          << ArgTyA
-          << SemaRef.Context.getVectorType(ArgTyA, 2, VectorKind::Generic) << 1
-          << 0 << 0;
-      return true;
-    }
-
-    ExprResult B = TheCall->getArg(1);
-    QualType ArgTyB = B.get()->getType();
-    auto *VTyB = ArgTyB->getAs<VectorType>();
-    if (VTyB == nullptr) {
-      SemaRef.Diag(B.get()->getBeginLoc(),
-                   diag::err_typecheck_convert_incompatible)
-          << ArgTyB
-          << SemaRef.Context.getVectorType(ArgTyB, 2, VectorKind::Generic) << 1
-          << 0 << 0;
+    // Use the helper function to check the first two arguments
+    if (CheckVectorArgs(TheCall, 2))
       return true;
-    }
 
     ExprResult C = TheCall->getArg(2);
     QualType ArgTyC = C.get()->getType();
-    if (!ArgTyC->hasFloatingRepresentation()) {
+    if (!ArgTyC->isFloatingType()) {
       SemaRef.Diag(C.get()->getBeginLoc(), diag::err_builtin_invalid_arg_type)
-          << 3 << /* scalar or vector */ 5 << /* no int */ 0 << /* fp */ 1
+          << 3 << /* scalar*/ 5 << /* no int */ 0 << /* fp */ 1
           << ArgTyC;
       return true;
     }
 
-    QualType RetTy = ArgTyA;
+    QualType RetTy = TheCall->getArg(0)->getType();
     TheCall->setType(RetTy);
     assert(RetTy == ArgTyA);
     //assert(ArgTyB == ArgTyA);

clang/test/CodeGenSPIRV/Builtins/refract.c

@@ -1,6 +1,6 @@
 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5
 
-// RUN: %clang_cc1 -triple spirv-pc-vulkan-compute %s -emit-llvm -o - | FileCheck %s
+// RUN: %clang_cc1 -O1 -triple spirv-pc-vulkan-compute %s -emit-llvm -o - | FileCheck %s
 
 typedef float float2 __attribute__((ext_vector_type(2)));
 typedef float float3 __attribute__((ext_vector_type(3)));