use c++-style references

Author: zimirza

libc/src/time/linux/localtime_utils.cpp

@@ -19,7 +19,7 @@ void release_file(ErrorOr<File *> error_or_file) {
   error_or_file.value()->close();
 }
 
-ErrorOr<File *> acquire_file(char *filename) {
+ErrorOr<File *> acquire_file(char& filename) {
   while (1) {
     if (file_usage == 0) {
       file_usage = 1;
@@ -30,7 +30,7 @@ ErrorOr<File *> acquire_file(char *filename) {
   return LIBC_NAMESPACE::openfile(filename, "rb");
 }
 
-timezone::tzset *get_localtime(struct tm *tm) {
+timezone::tzset& get_localtime(struct tm& tm) {
   (void)tm;
   return nullptr;
 }

libc/src/time/linux/localtime_utils.h

@@ -19,7 +19,7 @@ LIBC_INLINE volatile int file_usage;
 namespace LIBC_NAMESPACE_DECL {
 namespace localtime_utils {
 
-timezone::tzset *get_localtime(struct tm *tm);
+timezone::tzset& get_localtime(struct tm& tm);
 
 } // namespace localtime_utils
 } // namespace LIBC_NAMESPACE_DECL

libc/src/time/linux/timezone.cpp

@@ -13,7 +13,7 @@
 namespace LIBC_NAMESPACE_DECL {
 namespace timezone {
 
-tzset *get_tzset(File *file) {
+tzset& get_tzset(File& file) {
   static tzset result;
   (void)file;
 

libc/src/time/linux/timezone.h

@@ -29,7 +29,7 @@ typedef struct {
 
   // additional fields
   int64_t offsets;
-  size_t *size;
+  size_t& size;
 } ttinfo;
 
 typedef struct {
@@ -39,18 +39,18 @@ typedef struct {
   uint64_t tzh_timecnt;
   uint64_t tzh_typecnt;
   uint64_t tzh_charcnt;
-  ttinfo *ttinfo;
+  ttinfo& ttinfo;
 
   // additional fields
-  int64_t *tzh_timecnt_transitions;
-  int64_t *tzh_timecnt_indices;
+  int64_t& tzh_timecnt_transitions;
+  int64_t& tzh_timecnt_indices;
   size_t tzh_timecnt_number_transitions;
-  int64_t *tz;
+  int64_t& tz;
   int8_t global_offset;
   int8_t global_isdst;
 } tzset;
 
-tzset *get_tzset(::FILE *file);
+tzset& get_tzset(::FILE& file);
 
 } // namespace timezone
 } // namespace LIBC_NAMESPACE_DECL

libc/src/time/time_utils.h

@@ -106,19 +106,19 @@ LIBC_INLINE tm *localtime(const time_t *t_ptr) {
   return time_utils::gmtime_internal(t_ptr, &result);
 }
 
-LIBC_INLINE struct tm *localtime_internal(const time_t *timer, struct tm *buf) {
+LIBC_INLINE struct tm *localtime_internal(const time_t& timer, struct tm& buf) {
   if (timer == nullptr) {
     invalid_value();
     return nullptr;
   }
 
   // Update the tm structure's year, month, day, etc. from seconds.
-  if (update_from_seconds(static_cast<int64_t>(*timer), buf) < 0) {
+  if (update_from_seconds(static_cast<int64_t>(timer), &buf) < 0) {
     out_of_range();
     return nullptr;
   }
 
-  return buf;
+  return &buf;
 }
 
 // Returns number of years from (1, year).