Implement compound operator case with unsigned flags

Author: denzor200

clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp

@@ -13,6 +13,8 @@
 #include <optional>
 #include <utility>
 
+// TODO: change warning message
+
 using namespace clang::ast_matchers;
 
 namespace clang::tidy::misc {
@@ -99,6 +101,10 @@ static bool isBooleanBitwise(const BinaryOperator *BinOp, ASTContext *AC, std::o
         rootAssignsToBoolean = rootAssignsToBoolean.value_or(true);
         return true;
       }
+      if (BinOp->isCompoundAssignmentOp() && BinOp->getLHS()->IgnoreImpCasts()->getType().getTypePtr()->isBooleanType()) {
+        rootAssignsToBoolean = rootAssignsToBoolean.value_or(true);
+        return true;
+      }
     }
   }
   return false;
@@ -232,6 +238,7 @@ void BoolBitwiseOperationCheck::visitBinaryTreesNode(
     const BinaryOperator *BinOp, const BinaryOperator *ParentBinOp,
     const clang::SourceManager &SM, clang::ASTContext &Ctx,
     std::optional<bool>& rootAssignsToBoolean) {
+  //llvm::outs() << "ENTER " << rootAssignsToBoolean << "\n";
   if (!BinOp)
     return;
 
@@ -244,6 +251,8 @@ void BoolBitwiseOperationCheck::visitBinaryTreesNode(
   visitBinaryTreesNode(
       dyn_cast<BinaryOperator>(BinOp->getRHS()->IgnoreParenImpCasts()), BinOp,
       SM, Ctx, rootAssignsToBoolean);
+
+  //llvm::outs() << "LEAVE\n";
 }
 
 void BoolBitwiseOperationCheck::check(const MatchFinder::MatchResult &Result) {

clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-not-only-bool-operand-compound.cpp

@@ -0,0 +1,15 @@
+// RUN: %check_clang_tidy %s misc-bool-bitwise-operation %t
+
+void general(unsigned flags, bool value) {
+    flags |= value;
+}
+
+void assign_to_boolean(unsigned flags, bool value) {
+    value |= flags << 1;
+    // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: use logical operator '||' for boolean variable 'value' instead of bitwise operator '|=' [misc-bool-bitwise-operation]
+    // CHECK-FIXES: value = value || flags << 1;
+    value |= (flags << 1) | (flags << 2);
+    // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: use logical operator '||' for boolean variable 'value' instead of bitwise operator '|=' [misc-bool-bitwise-operation]
+    // CHECK-MESSAGES: :[[@LINE-2]]:27: warning: use logical operator '||' for boolean values instead of bitwise operator '|' [misc-bool-bitwise-operation]
+    // CHECK-FIXES: value = value || (flags << 1) || (flags << 2);
+}

clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-not-only-bool-operand.cpp

@@ -1,6 +1,6 @@
 // RUN: %check_clang_tidy %s misc-bool-bitwise-operation %t
 
-// got from clang/lib/APINotes/APINotesWriter.cpp
+// The case is taken from the real code in clang/lib/APINotes/APINotesWriter.cpp
 
 void general(unsigned flags, bool value) {
     (flags << 1) | value;
@@ -9,8 +9,8 @@ void general(unsigned flags, bool value) {
     flags = (flags << 1) | (flags << 2) | (flags << 4) | value;
 }
 
-// TODO: compound operators
 // TODO: make sure parens dont spoil prior for compound operators
+// TODO: r = value |= flags << 1; (when r boolean, value unsigned)
 
 void take(bool value) {}