Add canonicalization

Author: IgWod-IMG

mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGLOps.td

@@ -1196,6 +1196,7 @@ def SPIRV_GLLengthOp : SPIRV_GLOp<"Length", 66, [
   }];
 
   let hasVerifier = 0;
+  let hasCanonicalizer = 1;
 }
 
 // -----

mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.cpp

@@ -1403,3 +1403,12 @@ void spirv::SelectionOp::getCanonicalizationPatterns(RewritePatternSet &results,
                                                      MLIRContext *context) {
   results.add<ConvertSelectionOpToSelect>(context);
 }
+
+//===----------------------------------------------------------------------===//
+// spirv.GL.Length
+//===----------------------------------------------------------------------===//
+
+void spirv::GLLengthOp::getCanonicalizationPatterns(RewritePatternSet &results,
+                                                    MLIRContext *context) {
+  results.add<ConvertGLLengthToGLFAbs>(context);
+}

mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.td

@@ -75,3 +75,11 @@ def ConvertComparisonIntoClamp2_#CmpClampPair[0] : Pat<
         )),
     (CmpClampPair[1] $input, $min, $max)>;
 }
+
+//===----------------------------------------------------------------------===//
+// spirv.GL.Length -> spirv.GL.FAbs
+//===----------------------------------------------------------------------===//
+
+def ConvertGLLengthToGLFAbs : Pat<
+    (SPIRV_GLLengthOp SPIRV_Float:$operand),
+    (SPIRV_GLFAbsOp $operand)>;

mlir/test/Dialect/SPIRV/Transforms/canonicalize.mlir

@@ -2490,3 +2490,24 @@ func.func @cannot_canonicalize_selection_op_4(%cond: i1) -> () {
   }
   spirv.Return
 }
+
+// -----
+
+//===----------------------------------------------------------------------===//
+// spirv.GL.Length
+//===----------------------------------------------------------------------===//
+
+// CHECK-LABEL: @convert_length_into_fabs_scalar
+func.func @convert_length_in_fabs_scalar(%arg0 : f32) -> f32 {
+
+  %0 = spirv.GL.Length %arg0 : f32 -> f32
+  //%11 = spirv.GL.Length %arg1 : vector<3xf32> -> f32
+  spirv.ReturnValue %0 : f32
+}
+
+// CHECK-LABEL: @dont_convert_length_into_fabs_vec
+func.func @dont_convert_length_in_fabs_vec(%arg0 : vector<3xf32>) -> f32 {
+
+  %0 = spirv.GL.Length %arg0 : vector<3xf32> -> f32
+  spirv.ReturnValue %0 : f32
+}