Skip to content

Commit 7a61b7f

Browse files
committed
Address David's comments
1 parent 4157b0d commit 7a61b7f

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

lldb/source/Target/Statistics.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ llvm::json::Value DebuggerStats::ReportStatistics(
323323
if (symtab) {
324324
module_stat.num_symbols_loaded = symtab->GetNumSymbols();
325325
num_symbols_loaded += module_stat.num_symbols_loaded;
326-
symtabs_loaded++;
326+
++symtabs_loaded;
327327
module_stat.symtab_loaded_from_cache = symtab->GetWasLoadedFromCache();
328328
if (module_stat.symtab_loaded_from_cache)
329329
++symtabs_loaded_from_cache;

lldb/test/API/commands/statistics/basic/TestStats.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,16 @@ def test_default_no_run(self):
171171
"totalSymbolTablesLoadedFromCache",
172172
"totalSymbolTablesSavedToCache",
173173
"totalSymbolsLoaded",
174+
"totalSymbolTablesLoaded",
174175
"totalDebugInfoByteSize",
175176
"totalDebugInfoIndexTime",
176177
"totalDebugInfoIndexLoadedFromCache",
177178
"totalDebugInfoIndexSavedToCache",
178179
"totalDebugInfoParseTime",
179180
]
180181
self.verify_keys(debug_stats, '"debug_stats"', debug_stat_keys, None)
182+
self.assertGreater(debug_stats["totalSymbolsLoaded"], 0)
183+
self.assertGreater(debug_stats["totalSymbolTablesLoaded"], 0)
181184

182185
# Verify target stats keys.
183186
target_stats = debug_stats["targets"][0]
@@ -188,16 +191,23 @@ def test_default_no_run(self):
188191
"targetCreateTime",
189192
]
190193
target_stat_keys_missing = ["firstStopTime", "launchOrAttachTime"]
191-
self.verify_keys(target_stats, '"target_stats"', target_stat_keys_exist, target_stat_keys_missing)
194+
self.verify_keys(
195+
target_stats,
196+
'"target_stats"',
197+
target_stat_keys_exist,
198+
target_stat_keys_missing,
199+
)
192200
self.assertGreater(target_stats["targetCreateTime"], 0.0)
193201

194202
# Verify module stats keys.
195203
for module_stats in debug_stats["modules"]:
196204
module_stat_keys_exist = [
197205
"symbolsLoaded",
198206
]
199-
self.verify_keys(module_stats, '"module_stats"', module_stat_keys_exist, None)
200-
207+
self.verify_keys(
208+
module_stats, '"module_stats"', module_stat_keys_exist, None
209+
)
210+
self.assertGreater(module_stats["symbolsLoaded"], 0)
201211

202212
def test_default_with_run(self):
203213
"""Test "statistics dump" when running the target to a breakpoint.

0 commit comments

Comments
 (0)