Skip to content

Commit 7bda763

Browse files
authored
[LLDB][NativePDB] Ignore functions with no type in name lookup (#153382)
Some functions don't have the `FunctionType` set. We can't look these up and won't be able to call them, so ignore them when caching the function names. This does fix the failures caused by #153160 mentioned in #153160 (comment). However, in `lldb-shell::msstl_smoke.cpp` there's another failure not introduced by #153160 (fixed with #153386).
1 parent 179698a commit 7bda763

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1688,7 +1688,7 @@ void SymbolFileNativePDB::CacheFunctionNames() {
16881688
llvm::cantFail(SymbolDeserializer::deserializeAs<ProcSym>(*iter));
16891689
if ((proc.Flags & ProcSymFlags::IsUnreachable) != ProcSymFlags::None)
16901690
continue;
1691-
if (proc.Name.empty())
1691+
if (proc.Name.empty() || proc.FunctionType.isSimple())
16921692
continue;
16931693

16941694
// The function/procedure symbol only contains the demangled name.

0 commit comments

Comments
 (0)