Skip to content

Commit 7bff05f

Browse files
committed
Fix the test case on Windows; change variable names
1 parent 69c8d08 commit 7bff05f

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -786,10 +786,10 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable *GV) {
786786

787787
// Place the large common variables in the .lbss section for the medium and
788788
// large code models on x86_64. (AMD64 ABI, 9.2.5 COMMON blocks)
789-
MCSection *largeCommonSec =
789+
MCSection *LargeCommonSec =
790790
getObjFileLowering().LargeSectionForCommon(GV, GVKind, TM);
791-
if (largeCommonSec)
792-
OutStreamer->switchSection(largeCommonSec);
791+
if (LargeCommonSec)
792+
OutStreamer->switchSection(LargeCommonSec);
793793

794794
if (MAI->hasDotTypeDotSizeDirective())
795795
OutStreamer->emitSymbolAttribute(EmittedSym, MCSA_ELF_TypeObject);
@@ -809,7 +809,7 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable *GV) {
809809
if (GVKind.isCommon()) {
810810
if (Size == 0) Size = 1; // .comm Foo, 0 is undefined, avoid it.
811811
// .comm _foo, 42, 4
812-
if (largeCommonSec)
812+
if (LargeCommonSec)
813813
OutStreamer->emitLargeCommonSymbol(GVSym, Size, Alignment);
814814
else
815815
OutStreamer->emitCommonSymbol(GVSym, Size, Alignment);

llvm/lib/MC/MCParser/ELFAsmParser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@ bool ELFAsmParser::parseDirectiveCGProfile(StringRef S, SMLoc Loc) {
888888
return MCAsmParserExtension::parseDirectiveCGProfile(S, Loc);
889889
}
890890

891-
bool ELFAsmParser::parseDirectiveLargecomm(StringRef s, SMLoc Loc) {
891+
bool ELFAsmParser::parseDirectiveLargecomm(StringRef, SMLoc Loc) {
892892
if (getParser().checkForValidSection())
893893
return true;
894894

llvm/test/MC/X86/largecomm.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
; RUN: llc -filetype=asm -code-model=medium %s --large-data-threshold=65636 -o - | FileCheck %s --check-prefix=CHECKASM-MEDIUM
22
; RUN: llc -filetype=asm -code-model=large %s -o - | FileCheck %s --check-prefix=CHECKASM-LARGE
3-
; RUN: llc -filetype=asm -code-model=medium %s --large-data-threshold=65636 -o - | llvm-mc -filetype=obj - | llvm-readelf -s - | FileCheck %s --check-prefix=CHECKOBJ-MEDIUM
4-
; RUN: llc -filetype=asm -code-model=large %s -o - | llvm-mc -filetype=obj - | llvm-readelf -s - | FileCheck %s --check-prefix=CHECKOBJ-LARGE
3+
; RUN: llc -filetype=asm -code-model=medium %s --large-data-threshold=65636 -o - | llvm-mc -triple x86_64-linux-gnu -filetype=obj - | llvm-readelf -s - | FileCheck %s --check-prefix=CHECKOBJ-MEDIUM
4+
; RUN: llc -filetype=asm -code-model=large %s -o - | llvm-mc -triple x86_64-linux-gnu -filetype=obj - | llvm-readelf -s - | FileCheck %s --check-prefix=CHECKOBJ-LARGE
55

66
; CHECKASM-MEDIUM: .section .lbss,"awl",@nobits
77
; CHECKASM-MEDIUM-NEXT: .type __BLNK__,@object # @__BLNK__

0 commit comments

Comments
 (0)