Skip to content

Commit 7d40c70

Browse files
author
liuzhenya
committed
fix: review
1 parent 8c90efb commit 7d40c70

File tree

2 files changed

+16
-26
lines changed

2 files changed

+16
-26
lines changed

‎clang/test/CodeGen/X86/avx512f-builtins.c‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3302,7 +3302,7 @@ __m128 test_mm_mask_add_ss(__m128 __W, __mmask8 __U, __m128 __A, __m128 __B) {
33023302
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
33033303
return _mm_mask_add_ss(__W,__U,__A,__B);
33043304
}
3305-
TEST_CONSTEXPR(match_v4sf(_mm_mask_add_ss((__m128)(__v4sf){10.0f, 100.0f, 200.0f, 300.0f}, 0x1,(__m128)(__v4sf){1.25f, 3.0f, 4.0f, 5.0f},(__m128)(__v4sf){2.75f, 6.0f, 7.0f, 8.0f}),4.0f, 100.0f, 200.0f, 300.0f));
3305+
TEST_CONSTEXPR(match_m128(_mm_mask_add_ss((__m128)(__v4sf){10.0f, 100.0f, 200.0f, 300.0f}, 0x1,(__m128)(__v4sf){1.25f, 3.0f, 4.0f, 5.0f},(__m128)(__v4sf){2.75f, 6.0f, 7.0f, 8.0f}),4.0f, 100.0f, 200.0f, 300.0f));
33063306

33073307
__m128 test_mm_maskz_add_ss(__mmask8 __U, __m128 __A, __m128 __B) {
33083308
// CHECK-LABEL: test_mm_maskz_add_ss
@@ -3319,7 +3319,7 @@ __m128 test_mm_maskz_add_ss(__mmask8 __U, __m128 __A, __m128 __B) {
33193319
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
33203320
return _mm_maskz_add_ss(__U,__A,__B);
33213321
}
3322-
TEST_CONSTEXPR(match_v4sf(_mm_maskz_add_ss(0x1, (__m128)(__v4sf){1.25f, 3.0f, 4.0f, 5.0f}, (__m128)(__v4sf){2.75f, 6.0f, 7.0f, 8.0f}), 4.0f, 0.0f, 0.0f, 0.0f));
3322+
TEST_CONSTEXPR(match_m128(_mm_maskz_add_ss(0x1, (__m128)(__v4sf){1.25f, 3.0f, 4.0f, 5.0f}, (__m128)(__v4sf){2.75f, 6.0f, 7.0f, 8.0f}), 4.0f, 0.0f, 0.0f, 0.0f));
33233323

33243324
__m128d test_mm_add_round_sd(__m128d __A, __m128d __B) {
33253325
// CHECK-LABEL: test_mm_add_round_sd
@@ -3351,7 +3351,7 @@ __m128d test_mm_mask_add_sd(__m128d __W, __mmask8 __U, __m128d __A, __m128d __B)
33513351
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
33523352
return _mm_mask_add_sd(__W,__U,__A,__B);
33533353
}
3354-
TEST_CONSTEXPR(match_v2df(_mm_mask_add_sd((__m128d)(__v2df){10.0, 999.0}, 0x1, (__m128d)(__v2df){5.5, 77.0}, (__m128d)(__v2df){0.25, 88.0}), 5.75, 999.0));
3354+
TEST_CONSTEXPR(match_m128d(_mm_mask_add_sd((__m128d)(__v2df){10.0, 999.0}, 0x1, (__m128d)(__v2df){5.5, 77.0}, (__m128d)(__v2df){0.25, 88.0}), 5.75, 999.0));
33553355

33563356
__m128d test_mm_maskz_add_sd(__mmask8 __U, __m128d __A, __m128d __B) {
33573357
// CHECK-LABEL: test_mm_maskz_add_sd
@@ -3368,7 +3368,7 @@ __m128d test_mm_maskz_add_sd(__mmask8 __U, __m128d __A, __m128d __B) {
33683368
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
33693369
return _mm_maskz_add_sd(__U,__A,__B);
33703370
}
3371-
TEST_CONSTEXPR(match_v2df(_mm_maskz_add_sd(0x1, (__m128d)(__v2df){5.5, 77.0}, (__m128d)(__v2df){0.25, 88.0}), 5.75, 0.0));
3371+
TEST_CONSTEXPR(match_m128d(_mm_maskz_add_sd(0x1, (__m128d)(__v2df){5.5, 77.0}, (__m128d)(__v2df){0.25, 88.0}), 5.75, 0.0));
33723372

33733373
__m512d test_mm512_sub_round_pd(__m512d __A, __m512d __B) {
33743374
// CHECK-LABEL: test_mm512_sub_round_pd
@@ -3458,7 +3458,7 @@ __m128 test_mm_mask_sub_ss(__m128 __W, __mmask8 __U, __m128 __A, __m128 __B) {
34583458
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
34593459
return _mm_mask_sub_ss(__W,__U,__A,__B);
34603460
}
3461-
TEST_CONSTEXPR(match_v4sf(_mm_mask_sub_ss((__m128)(__v4sf){-1.0f, 10.0f, 20.0f, 30.0f}, 0x1, (__m128)(__v4sf){7.0f, 3.0f, 4.0f, 5.0f}, (__m128)(__v4sf){2.5f, 6.0f, 7.0f, 8.0f}), 4.5f, 10.0f, 20.0f, 30.0f));
3461+
TEST_CONSTEXPR(match_m128(_mm_mask_sub_ss((__m128)(__v4sf){-1.0f, 10.0f, 20.0f, 30.0f}, 0x1, (__m128)(__v4sf){7.0f, 3.0f, 4.0f, 5.0f}, (__m128)(__v4sf){2.5f, 6.0f, 7.0f, 8.0f}), 4.5f, 10.0f, 20.0f, 30.0f));
34623462

34633463
__m128 test_mm_maskz_sub_ss(__mmask8 __U, __m128 __A, __m128 __B) {
34643464
// CHECK-LABEL: test_mm_maskz_sub_ss
@@ -3475,7 +3475,7 @@ __m128 test_mm_maskz_sub_ss(__mmask8 __U, __m128 __A, __m128 __B) {
34753475
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
34763476
return _mm_maskz_sub_ss(__U,__A,__B);
34773477
}
3478-
TEST_CONSTEXPR(match_v4sf(_mm_maskz_sub_ss(0x1, (__m128)(__v4sf){7.0f, 3.0f, 4.0f, 5.0f}, (__m128)(__v4sf){2.5f, 6.0f, 7.0f, 8.0f}), 4.5f, 0.0f, 0.0f, 0.0f));
3478+
TEST_CONSTEXPR(match_m128(_mm_maskz_sub_ss(0x1, (__m128)(__v4sf){7.0f, 3.0f, 4.0f, 5.0f}, (__m128)(__v4sf){2.5f, 6.0f, 7.0f, 8.0f}), 4.5f, 0.0f, 0.0f, 0.0f));
34793479

34803480
__m128d test_mm_sub_round_sd(__m128d __A, __m128d __B) {
34813481
// CHECK-LABEL: test_mm_sub_round_sd
@@ -3507,7 +3507,7 @@ __m128d test_mm_mask_sub_sd(__m128d __W, __mmask8 __U, __m128d __A, __m128d __B)
35073507
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
35083508
return _mm_mask_sub_sd(__W,__U,__A,__B);
35093509
}
3510-
TEST_CONSTEXPR(match_v2df(_mm_mask_sub_sd((__m128d)(__v2df){-1.0, 111.0}, 0x1, (__m128d)(__v2df){9.0, 70.0}, (__m128d)(__v2df){3.5, 80.0}), 5.5, 111.0));
3510+
TEST_CONSTEXPR(match_m128d(_mm_mask_sub_sd((__m128d)(__v2df){-1.0, 111.0}, 0x1, (__m128d)(__v2df){9.0, 70.0}, (__m128d)(__v2df){3.5, 80.0}), 5.5, 111.0));
35113511

35123512
__m128d test_mm_maskz_sub_sd(__mmask8 __U, __m128d __A, __m128d __B) {
35133513
// CHECK-LABEL: test_mm_maskz_sub_sd
@@ -3524,7 +3524,7 @@ __m128d test_mm_maskz_sub_sd(__mmask8 __U, __m128d __A, __m128d __B) {
35243524
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
35253525
return _mm_maskz_sub_sd(__U,__A,__B);
35263526
}
3527-
TEST_CONSTEXPR(match_v2df(_mm_maskz_sub_sd(0x1, (__m128d)(__v2df){9.0, 70.0}, (__m128d)(__v2df){3.5, 80.0}), 5.5, 0.0));
3527+
TEST_CONSTEXPR(match_m128d(_mm_maskz_sub_sd(0x1, (__m128d)(__v2df){9.0, 70.0}, (__m128d)(__v2df){3.5, 80.0}), 5.5, 0.0));
35283528

35293529
__m512d test_mm512_mul_round_pd(__m512d __A, __m512d __B) {
35303530
// CHECK-LABEL: test_mm512_mul_round_pd
@@ -3614,7 +3614,7 @@ __m128 test_mm_mask_mul_ss(__m128 __W, __mmask8 __U, __m128 __A, __m128 __B) {
36143614
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
36153615
return _mm_mask_mul_ss(__W,__U,__A,__B);
36163616
}
3617-
TEST_CONSTEXPR(match_v4sf(_mm_mask_mul_ss((__m128)(__v4sf){42.0f, -1.0f, -2.0f, -3.0f}, 0x1, (__m128)(__v4sf){6.0f, 9.0f, 9.0f, 9.0f}, (__m128)(__v4sf){7.0f, 8.0f, 8.0f, 8.0f}), 42.0f, -1.0f, -2.0f, -3.0f));
3617+
TEST_CONSTEXPR(match_m128(_mm_mask_mul_ss((__m128)(__v4sf){42.0f, -1.0f, -2.0f, -3.0f}, 0x1, (__m128)(__v4sf){6.0f, 9.0f, 9.0f, 9.0f}, (__m128)(__v4sf){7.0f, 8.0f, 8.0f, 8.0f}), 42.0f, -1.0f, -2.0f, -3.0f));
36183618

36193619
__m128 test_mm_maskz_mul_ss(__mmask8 __U, __m128 __A, __m128 __B) {
36203620
// CHECK-LABEL: test_mm_maskz_mul_ss
@@ -3631,7 +3631,7 @@ __m128 test_mm_maskz_mul_ss(__mmask8 __U, __m128 __A, __m128 __B) {
36313631
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
36323632
return _mm_maskz_mul_ss(__U,__A,__B);
36333633
}
3634-
TEST_CONSTEXPR(match_v4sf(_mm_maskz_mul_ss(0x1, (__m128)(__v4sf){6.0f, 9.0f, 9.0f, 9.0f}, (__m128)(__v4sf){7.0f, 8.0f, 8.0f, 8.0f}), 42.0f, 0.0f, 0.0f, 0.0f));
3634+
TEST_CONSTEXPR(match_m128(_mm_maskz_mul_ss(0x1, (__m128)(__v4sf){6.0f, 9.0f, 9.0f, 9.0f}, (__m128)(__v4sf){7.0f, 8.0f, 8.0f, 8.0f}), 42.0f, 0.0f, 0.0f, 0.0f));
36353635

36363636
__m128d test_mm_mul_round_sd(__m128d __A, __m128d __B) {
36373637
// CHECK-LABEL: test_mm_mul_round_sd
@@ -3663,7 +3663,7 @@ __m128d test_mm_mask_mul_sd(__m128d __W, __mmask8 __U, __m128d __A, __m128d __B)
36633663
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
36643664
return _mm_mask_mul_sd(__W,__U,__A,__B);
36653665
}
3666-
TEST_CONSTEXPR(match_v2df(_mm_mask_mul_sd((__m128d)(__v2df){123.0, -9.0}, 0x1, (__m128d)(__v2df){2.5, 1.0}, (__m128d)(__v2df){4.0, 2.0}), 10.0, -9.0));
3666+
TEST_CONSTEXPR(match_m128d(_mm_mask_mul_sd((__m128d)(__v2df){123.0, -9.0}, 0x1, (__m128d)(__v2df){2.5, 1.0}, (__m128d)(__v2df){4.0, 2.0}), 10.0, -9.0));
36673667

36683668
__m128d test_mm_maskz_mul_sd(__mmask8 __U, __m128d __A, __m128d __B) {
36693669
// CHECK-LABEL: test_mm_maskz_mul_sd
@@ -3680,7 +3680,7 @@ __m128d test_mm_maskz_mul_sd(__mmask8 __U, __m128d __A, __m128d __B) {
36803680
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
36813681
return _mm_maskz_mul_sd(__U,__A,__B);
36823682
}
3683-
TEST_CONSTEXPR(match_v2df(_mm_maskz_mul_sd(0x1, (__m128d)(__v2df){2.5, 1.0}, (__m128d)(__v2df){4.0, 2.0}), 10.0, 0.0));
3683+
TEST_CONSTEXPR(match_m128d(_mm_maskz_mul_sd(0x1, (__m128d)(__v2df){2.5, 1.0}, (__m128d)(__v2df){4.0, 2.0}), 10.0, 0.0));
36843684

36853685
__m512d test_mm512_div_round_pd(__m512d __A, __m512d __B) {
36863686
// CHECK-LABEL: test_mm512_div_round_pd
@@ -3781,7 +3781,7 @@ __m128 test_mm_mask_div_ss(__m128 __W, __mmask8 __U, __m128 __A, __m128 __B) {
37813781
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
37823782
return _mm_mask_div_ss(__W,__U,__A,__B);
37833783
}
3784-
TEST_CONSTEXPR(match_v4sf(_mm_mask_div_ss((__m128)(__v4sf){-7.0f, 5.0f, 6.0f, 7.0f}, 0x1, (__m128)(__v4sf){9.0f, 1.0f, 1.0f, 1.0f}, (__m128)(__v4sf){3.0f, 2.0f, 2.0f, 2.0f}), 3.0f, 5.0f, 6.0f, 7.0f));
3784+
TEST_CONSTEXPR(match_m128(_mm_mask_div_ss((__m128)(__v4sf){-7.0f, 5.0f, 6.0f, 7.0f}, 0x1, (__m128)(__v4sf){9.0f, 1.0f, 1.0f, 1.0f}, (__m128)(__v4sf){3.0f, 2.0f, 2.0f, 2.0f}), 3.0f, 5.0f, 6.0f, 7.0f));
37853785

37863786
__m128 test_mm_maskz_div_ss(__mmask8 __U, __m128 __A, __m128 __B) {
37873787
// CHECK-LABEL: test_mm_maskz_div_ss
@@ -3797,7 +3797,7 @@ __m128 test_mm_maskz_div_ss(__mmask8 __U, __m128 __A, __m128 __B) {
37973797
// CHECK-NEXT: insertelement <4 x float> %{{.*}}, float %{{.*}}, i64 0
37983798
return _mm_maskz_div_ss(__U,__A,__B);
37993799
}
3800-
TEST_CONSTEXPR(match_v4sf(_mm_maskz_div_ss(0x1, (__m128)(__v4sf){9.0f, 1.0f, 1.0f, 1.0f}, (__m128)(__v4sf){3.0f, 2.0f, 2.0f, 2.0f}), 3.0f, 0.0f, 0.0f, 0.0f));
3800+
TEST_CONSTEXPR(match_m128(_mm_maskz_div_ss(0x1, (__m128)(__v4sf){9.0f, 1.0f, 1.0f, 1.0f}, (__m128)(__v4sf){3.0f, 2.0f, 2.0f, 2.0f}), 3.0f, 0.0f, 0.0f, 0.0f));
38013801

38023802
__m128d test_mm_div_round_sd(__m128d __A, __m128d __B) {
38033803
// CHECK-LABEL: test_mm_div_round_sd
@@ -3828,7 +3828,7 @@ __m128d test_mm_mask_div_sd(__m128d __W, __mmask8 __U, __m128d __A, __m128d __B)
38283828
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
38293829
return _mm_mask_div_sd(__W,__U,__A,__B);
38303830
}
3831-
TEST_CONSTEXPR(match_v2df(_mm_mask_div_sd((__m128d)(__v2df){-8.0, 44.0}, 0x1, (__m128d)(__v2df){8.0, 10.0}, (__m128d)(__v2df){2.0, 20.0}), 4.0, 44.0));
3831+
TEST_CONSTEXPR(match_m128d(_mm_mask_div_sd((__m128d)(__v2df){-8.0, 44.0}, 0x1, (__m128d)(__v2df){8.0, 10.0}, (__m128d)(__v2df){2.0, 20.0}), 4.0, 44.0));
38323832

38333833
__m128d test_mm_maskz_div_sd(__mmask8 __U, __m128d __A, __m128d __B) {
38343834
// CHECK-LABEL: test_mm_maskz_div_sd
@@ -3844,7 +3844,7 @@ __m128d test_mm_maskz_div_sd(__mmask8 __U, __m128d __A, __m128d __B) {
38443844
// CHECK-NEXT: insertelement <2 x double> %{{.*}}, double %{{.*}}, i64 0
38453845
return _mm_maskz_div_sd(__U,__A,__B);
38463846
}
3847-
TEST_CONSTEXPR(match_v2df(_mm_maskz_div_sd(0x1, (__m128d)(__v2df){8.0, 10.0}, (__m128d)(__v2df){2.0, 20.0}), 4.0, 0.0));
3847+
TEST_CONSTEXPR(match_m128d(_mm_maskz_div_sd(0x1, (__m128d)(__v2df){8.0, 10.0}, (__m128d)(__v2df){2.0, 20.0}), 4.0, 0.0));
38483848

38493849
__m128 test_mm_max_round_ss(__m128 __A, __m128 __B) {
38503850
// CHECK-LABEL: test_mm_max_round_ss

‎clang/test/CodeGen/X86/builtin_test_helpers.h‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,6 @@ constexpr bool match_v2du(__m128i _v, unsigned long long a, unsigned long long b
8080
return v[0] == a && v[1] == b;
8181
}
8282

83-
constexpr bool match_v2df(__m128d _v, double a, double b){
84-
__v2df v = (__v2df)_v;
85-
return v[0] == a && v[1] == b;
86-
}
87-
8883
constexpr bool match_v4si(__m128i _v, int a, int b, int c, int d) {
8984
__v4si v = (__v4si)_v;
9085
return v[0] == a && v[1] == b && v[2] == c && v[3] == d;
@@ -95,11 +90,6 @@ constexpr bool match_v4su(__m128i _v, unsigned a, unsigned b, unsigned c, unsign
9590
return v[0] == a && v[1] == b && v[2] == c && v[3] == d;
9691
}
9792

98-
constexpr bool match_v4sf(__m128 _v, float a, float b, float c, float d) {
99-
__v4sf v = (__v4sf)_v;
100-
return v[0] == a && v[1] == b && v[2] == c && v[3] == d;
101-
}
102-
10393
constexpr bool match_v8hi(__m128i _v, short a, short b, short c, short d, short e, short f, short g, short h) {
10494
__v8hi v = (__v8hi)_v;
10595
return v[0] == a && v[1] == b && v[2] == c && v[3] == d && v[4] == e && v[5] == f && v[6] == g && v[7] == h;

0 commit comments

Comments
 (0)