Skip to content

Commit 7df9043

Browse files
committed
Address review comment
1 parent c37e402 commit 7df9043

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5334,17 +5334,13 @@ static SDValue lowerVECTOR_SHUFFLE(SDValue Op, SelectionDAG &DAG,
53345334
// Recognize if one half is actually undef; the matching above will
53355335
// otherwise reuse the even stream for the undef one. This improves
53365336
// spread(2) shuffles.
5337-
bool EvenIsUndef = true, OddIsUndef = true;
5338-
for (unsigned i = 0; i < Mask.size(); i++) {
5339-
if (i % 2 == 0)
5340-
EvenIsUndef &= (Mask[i] == -1);
5341-
else
5342-
OddIsUndef &= (Mask[i] == -1);
5343-
}
5337+
bool LaneIsUndef[2] = { true, true};
5338+
for (unsigned i = 0; i < Mask.size(); i++)
5339+
LaneIsUndef[i % 2] &= (Mask[i] == -1);
53445340

53455341
int Size = Mask.size();
53465342
SDValue EvenV, OddV;
5347-
if (EvenIsUndef) {
5343+
if (LaneIsUndef[0]) {
53485344
EvenV = DAG.getUNDEF(HalfVT);
53495345
} else {
53505346
assert(EvenSrc >= 0 && "Undef source?");
@@ -5353,7 +5349,7 @@ static SDValue lowerVECTOR_SHUFFLE(SDValue Op, SelectionDAG &DAG,
53535349
DAG.getVectorIdxConstant(EvenSrc % Size, DL));
53545350
}
53555351

5356-
if (OddIsUndef) {
5352+
if (LaneIsUndef[1]) {
53575353
OddV = DAG.getUNDEF(HalfVT);
53585354
} else {
53595355
assert(OddSrc >= 0 && "Undef source?");

0 commit comments

Comments
 (0)