Address code review comments

Author: AmrDeveloper

clang/include/clang/CIR/MissingFeatures.h

@@ -94,6 +94,7 @@ struct MissingFeatures {
   static bool opFuncNoReturn() { return false; }
   static bool setFunctionAttributes() { return false; }
   static bool setLLVMFunctionFEnvAttributes() { return false; }
+  static bool setFunctionPersonality() { return false; }
 
   // CallOp handling
   static bool opCallAggregateArgs() { return false; }
@@ -349,7 +350,6 @@ struct MissingFeatures {
   static bool awaitOp() { return false; }
   static bool callOp() { return false; }
   static bool ifOp() { return false; }
-  static bool invokeOp() { return false; }
   static bool labelOp() { return false; }
   static bool ptrDiffOp() { return false; }
   static bool llvmLoweringPtrDiffConsidersPointee() { return false; }

clang/lib/CIR/CodeGen/CIRGenCall.cpp

@@ -636,8 +636,6 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo,
   assert(!cir::MissingFeatures::opCallAttrs());
   cgm.constructAttributeList(callee.getAbstractInfo(), attrs);
 
-  assert(!cir::MissingFeatures::invokeOp());
-
   cir::FuncType indirectFuncTy;
   mlir::Value indirectFuncVal;
   cir::FuncOp directFuncOp;

clang/lib/CIR/CodeGen/CIRGenException.cpp

@@ -612,6 +612,10 @@ void CIRGenFunction::populateEHCatchRegions(EHScopeStack::stable_iterator scope,
   ehScope.setMayThrow(mayThrow);
 }
 
+// in classic codegen this function is mapping to `isInvokeDest` previously and
+// currently it's mapping to the conditions that performs early returns in
+// `getInvokeDestImpl`, in CIR we need the condition to know if the EH scope may
+// throw exception or now.
 bool CIRGenFunction::isCatchOrCleanupRequired() {
   if (!ehStack.requiresCatchOrCleanup())
     return false;
@@ -633,11 +637,14 @@ bool CIRGenFunction::isCatchOrCleanupRequired() {
   return true;
 }
 
+// In classic codegen this function is equivalent to `getInvokeDestImpl`, in
+// ClangIR we don't need to return to return any landing pad, we just need to
+// populate the catch handlers if they are required
 void CIRGenFunction::populateCatchHandlersIfRequired(cir::TryOp tryOp) {
   assert(ehStack.requiresCatchOrCleanup());
   assert(!ehStack.empty());
 
-  // TODO(cir): add personality function
+  assert(!cir::MissingFeatures::setFunctionPersonality());
 
   // CIR does not cache landing pads.
   const EHPersonality &personality = EHPersonality::get(*this);